Fullscreen hotkey not working

[bhajneet]

Describe the bug

Can't full screen on windows, possibly introduced by fixing mac hotkeys

Step to reproduce behavior

Expected behavior

Screenshots

Bug environment

• Device:
• OS: Windows
• Browser:
• Version:

[bhajneet]

Everything looks good in c99270e

So I would suggest pulling a reference before this to see if the hotkeys are working to single out this commit. If there is an issue in this commit we have to figure it out for windows users.

@saihaj do you think you can fix this?

[saihaj]

I don't have a windows workstation to test so not much I can do. @Harjot1Singh can you take a look?

[bhajneet]

Also, idk if you want to bundle in this tracker, but apple+Q is not working on main Shabad OS window on macOS

[saihaj]

I don't think it worked before #548 (comment)

[Harjot1Singh]

I believe this issue was introduced by updating Electron - the window.require('electron') is throwing an exception. Strangely, this is not appearing in Sentry.

I do not believe this is possible to have been introduced in the mac bar settings PR - did you re-install electron after rolling back?

If it isn't that, something has been changed/updated to cause window.require('electron') to no longer be valid

[Harjot1Singh]

See this breaking change: https://www.electronjs.org/docs/latest/breaking-changes#deprecated-remote-module