Support tor-specific socks error messages #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robgjansen
approved these changes
Sep 18, 2021
| @@ -1121,6 +1121,38 @@ static TGenEvent _tgentransport_receiveSocksResponseStatus(TGenTransport* transp | |||
| g_string_append_printf(messageBuffer, "address type not supported"); | |||
| break; | |||
| } | |||
| case 0xF0: { | |||
There was a problem hiding this comment.
If we connect to a non-Tor SOCKS proxy (which I realize is unlikely given tgen's main purpose), is it possible that they send us these error codes but they have a different meaning? Might be worth a comment in the code?
stevenengler
force-pushed
the
socks-tor-errors
branch
from
5925455
to
7b12598
Compare
The socks port 'ExtendedErrors' flag must be set in the tor configuration for tor to return these error codes.
stevenengler
force-pushed
the
socks-tor-errors
branch
from
7b12598
to
b092b9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socks port 'ExtendedErrors' flag must be set in the tor configuration for tor to return these error codes.