Get tgen working on all shadow-supported platforms #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporksmith
force-pushed
the
handle-igraph-0.9
branch
from
5ea9bd9
to
03ab465
Compare
robgjansen
requested changes
Dec 8, 2021
sporksmith
force-pushed
the
handle-igraph-0.9
branch
from
03ab465
to
ecd2604
Compare
sporksmith
changed the title
|
Thanks! Could you change the required checks to be the new parameterized tests instead of the old one? |
|
Yep, just noticed that - done now! |
This fixes the build for igraph 0.9.0+, in which `igraph_i_attribute_gettype` has been removed: igraph/igraph@463cc7c `igraph_cattribute_table.gettype` appears to be the only viable alternative. It looks like it's intended to be called by igraph itself, not by users of igraph, but there doesn't appear to be any other API for checking attribute types.
sporksmith
force-pushed
the
handle-igraph-0.9
branch
from
d213a50
to
fc52b53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a platform matrix to the CI that tests the same set of platforms as in Shadow.
Fixes the build for igraph 0.9+, which is the default on fedora:34