fix(shadowsocks): thiserror v2 ProtocolError fix embiguous #113
Annotations
4 warnings
useless use of `format!`:
crates/shadowsocks-service/src/manager/server.rs#L486
warning: useless use of `format!`
--> crates/shadowsocks-service/src/manager/server.rs:486:39
|
486 | return Ok(AddResponse(format!("invalid server")));
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"invalid server".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
crates/shadowsocks/src/config.rs#L490
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks/src/config.rs:490:60
|
490 | fn password_to_keys<P>(method: CipherKind, password: P) -> Result<(String, Box<[u8]>, Vec<Bytes>), ServerConfigError>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|
useless use of `format!`:
crates/shadowsocks-service/src/manager/server.rs#L486
warning: useless use of `format!`
--> crates/shadowsocks-service/src/manager/server.rs:486:39
|
486 | return Ok(AddResponse(format!("invalid server")));
| ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"invalid server".to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
very complex type used. Consider factoring parts into `type` definitions:
crates/shadowsocks/src/config.rs#L490
warning: very complex type used. Consider factoring parts into `type` definitions
--> crates/shadowsocks/src/config.rs:490:60
|
490 | fn password_to_keys<P>(method: CipherKind, password: P) -> Result<(String, Box<[u8]>, Vec<Bytes>), ServerConfigError>
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: `#[warn(clippy::type_complexity)]` on by default
|