core/libraries: WIP Videodec2 implementation #1241
Conversation
polybiusproxy
force-pushed
the
core/vdec2
branch
from
bc9849b
to
c85122f
Compare
|
Latest commit fixes crashes on Persona 5 Royal. |
|
@vladmikhalin can you review this? |
It's still a draft, is it ready for review? |
|
it is ready |
It's still marked as a draft but I'd still want you to review it |
| } | ||
|
|
||
| AVFrame* frame = av_frame_alloc(); | ||
| ret = avcodec_receive_frame(mCodecContext, frame); |
There was a problem hiding this comment.
One packet can contain several frames. You should drain them all until AVERROR(EAGAIN) or AVERROR_EOF is returned. What you can do here is call avcodec_receive_frame before avcodec_send_packet to query the decoder on available frames. Only if it returns AVERROR(EAGAIN) you should call avcodec_send_packet again.
| outputInfo.pictureCount = 0; | ||
|
|
||
| packet->data = (u8*)inputData.pAuData; | ||
| packet->size = inputData.auSize; |
There was a problem hiding this comment.
You can set packet->pts to inputData.ptsData and packet->dts to inputData.dtsData
|
what other games uses videcodec2 expect persona???? |
Work-in-progress and very basic implementation of the Videodec2 library.
