Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sceKernelGetModuleList #806

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ItsStolas
Copy link
Contributor

@ItsStolas ItsStolas commented Sep 6, 2024

Tried to implement sceKernelGetModuleList

Called in CUSA09316 (shadps4-emu/shadps4-game-compatibility#136)

@ItsStolas
Copy link
Contributor Author

Hmm, I didn't touch the failing file on macOs

@viniciuslrangel
Copy link
Contributor

Hmm, I didn't touch the failing file on macOs

Prob function was used somewhere which had included. Move implementation of this function

shadPS4/src/core/module.h

Lines 168 to 175 in c74d653

void* FindByName(std::string_view name) {
const auto symbols = export_sym.GetSymbols();
const auto it = std::ranges::find(symbols, name, &Loader::SymbolRecord::nid_name);
if (it != symbols.end()) {
return reinterpret_cast<void*>(it->virtual_address);
}
return nullptr;
}
to the .cpp file

Comment on lines 82 to 83
int GetNumberModules() const {
return m_modules.size();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok to keep

@Hermiten
Copy link
Collaborator

Hermiten commented Oct 4, 2024

Is it finish ? @ItsStolas @viniciuslrangel
Thanks you :)

@@ -398,6 +399,23 @@ int PS4_SYSV_ABI posix_getpagesize() {
return 4096;
}

int PS4_SYSV_ABI sceKernelGetModuleList(Core::Module** pArray, size_t numArray,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core::Module is our structure, not sure it matches what guest expects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants