Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run-time issues on Ubuntu 22.04LTS due to python changes related to abc.collections, patch included. #1192

Closed
Brainiarc7 opened this issue Mar 16, 2023 · 0 comments · Fixed by #1188 or #1312
Closed

Run-time issues on Ubuntu 22.04LTS due to python changes related to abc.collections, patch included. #1192

Brainiarc7 opened this issue Mar 16, 2023 · 0 comments · Fixed by #1188 or #1312
Labels
status: archived Archived and locked; will not be updated

Comments

@Brainiarc7
Copy link
Contributor

System info

Operating System: Ubuntu 22.04LTS
Shaka Packager Version: git tip master

Issue and steps to reproduce the problem

On Ubuntu 22.04LTS, running an invocation of pssh-box.py tool would result in an error similar to:

AttributeError: module 'collections' has no attribute 'abc'

I've included a patch #1188 that resolves this.
Please review.
@joeyparrish joeyparrish mentioned this issue May 1, 2023
Merged
joeyparrish pushed a commit that referenced this issue May 1, 2023
@Brainiarc7
fix: Fix issues with collections.abc in Python 3.10+ (#1188)
80e0240 
This issue is observed on Python 3.10+ and above.
This workaround addresses a major backwards compatibility break with a
major Python release version where collections.abc isn't available.

Fixes #1192
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
1 participant
@Brainiarc7