Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duration is not set in the init segment in static live profile #340

Closed
kqyang opened this issue Mar 3, 2018 · 0 comments
Closed

Duration is not set in the init segment in static live profile #340

kqyang opened this issue Mar 3, 2018 · 0 comments
Assignees
@kqyang
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.1

Comments

@kqyang
Copy link
Contributor

kqyang commented Mar 3, 2018

I cannot find any reference in DASH (23009-1:2014) spec or DASH-IF-IOP whether the duration should be set for static mpd with live profile.

Since the duration is available, we should probably update the init segment with the stream duration.

It is also necessary to do smooth playback of a high bitrate content in Chrome. As with duration set to 0, LIVENESS_LIVE is set and Chrome enters low delay mode, which may cause stalls for high bitrate content (https://bugs.chromium.org/p/chromium/issues/detail?id=818341#c10).
@kqyang kqyang added the type: bug Something isn't working correctly label Mar 3, 2018
@kqyang kqyang added this to the 2.1.0 milestone Mar 3, 2018
@kqyang kqyang self-assigned this Mar 3, 2018
kqyang added a commit that referenced this issue Mar 6, 2018
@kqyang
Rewrite init segment in MultiSegmentSegmenter::DoFinalize
db418ab 
This is called when reaching end of the file of the media. The duration
of the media is updated.

Fixes #340.

Change-Id: I446f2d341b02125d4a7d8c958bda269b5403cb9c
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 5, 2018
@shaka-project shaka-project locked and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kqyang kqyang

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.1
Development

No branches or pull requests
2 participants
@kqyang @shaka-bot