Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report an error or warning if DASH/HLS type is not set to live for UDP inputs #347

Closed
kqyang opened this issue Mar 8, 2018 · 1 comment
Closed

Report an error or warning if DASH/HLS type is not set to live for UDP inputs #347

kqyang opened this issue Mar 8, 2018 · 1 comment
Assignees
@kqyang
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.2

Comments

@kqyang
Copy link
Contributor

kqyang commented Mar 8, 2018

For static or on-demand types, manifests are written only once in the end of media. For UDP inputs, it usually never ends, so manifests are not written to disc. It could be difficult to figure out where the problem is.

We should report an error or warning in this case.
@kqyang kqyang added the type: enhancement New feature or request label Mar 8, 2018
@kqyang kqyang added this to the v2.1 milestone Mar 8, 2018
@kqyang kqyang modified the milestones: v2.1, v2.2 Mar 31, 2018
@kqyang kqyang mentioned this issue May 30, 2018
Closed
@kqyang kqyang self-assigned this Jun 5, 2018
@kqyang
Copy link
Contributor Author

kqyang commented Jun 29, 2018

Cherry-picked to v2.1.1.

kqyang added a commit that referenced this issue Jun 29, 2018
@kqyang
Warns if HLS type is not set to LIVE for UDP inputs
099c9ab 
- Also fixed documentation missing --hls_playlist_type LIVE for HLS
  live examples.
- Also updated packager.cc to use RETURN_IF_ERROR macro for
  consistency.

Fixes #347
Fixes #403

Change-Id: Idbccd7137b873170cd54e2c780bd554d25031a0b
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 6, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kqyang kqyang

Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
2 participants
@kqyang @shaka-bot