Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default language parameter ignored? #371

Closed
jakubvojacek opened this issue Apr 4, 2018 · 3 comments
Closed

default language parameter ignored? #371

jakubvojacek opened this issue Apr 4, 2018 · 3 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@jakubvojacek
Copy link

System info

Operating System: Debian latest
Shaka Packager Version: daac686

Issue and steps to reproduce the problem

Packager Command:

packager  'in=udp://239.100.0.23:1234?interface=172.16.128.42&reuse=1,stream=video,bandwidth=700000,init_segment=eurosport-1-hd-test-52_video_640_360.mp4,segment_template=video_640_360/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1235?interface=172.16.128.42&reuse=1,stream=video,bandwidth=1000000,init_segment=eurosport-1-hd-test-52_video_720_410.mp4,segment_template=video_720_410/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1236?interface=172.16.128.42&reuse=1,stream=video,bandwidth=2500000,init_segment=eurosport-1-hd-test-52_video_1280_720.mp4,segment_template=video_1280_720/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1237?interface=172.16.128.42&reuse=1,stream=video,bandwidth=4000000,init_segment=eurosport-1-hd-test-52_video_1920_1080.mp4,segment_template=video_1920_1080/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1255?interface=172.16.128.42&reuse=1,stream=audio,language=cs, init_segment=eurosport-1-hd-test-52_audio_cs.mp4,segment_template=audio_cs/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1256?interface=172.16.128.42&reuse=1,stream=audio,language=en, init_segment=eurosport-1-hd-test-52_audio_en.mp4,segment_template=audio_en/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1257?interface=172.16.128.42&reuse=1,stream=audio,language=hu, init_segment=eurosport-1-hd-test-52_audio_hu.mp4,segment_template=audio_hu/eurosport-1-hd-test-52-$Number$.mp4' 'in=udp://239.100.0.23:1258?interface=172.16.128.42&reuse=1,stream=audio,language=ro, init_segment=eurosport-1-hd-test-52_audio_ro.mp4,segment_template=audio_ro/eurosport-1-hd-test-52-$Number$.mp4' --time_shift_buffer_depth 15000 --hls_playlist_type LIVE --hls_master_playlist_output eurosport-1-hd-test-52.m3u8 --mpd_output eurosport-1-hd-test-52.mpd --fragment_duration 3.2 --segment_duration 3.2  --suggested_presentation_delay 5 --min_buffer_time 3.2 --minimum_update_period 5 --default_language=cs

What is the expected result?
I would expect that audio with lang cs would have tag role main. But it did not have. Is this --default_language not being used?

This is the generated MPD

<?xml version="1.0" encoding="UTF-8"?>
<!--Generated with https://github.com/google/shaka-packager version daac6869fb-release-->
<MPD xmlns="urn:mpeg:dash:schema:mpd:2011" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xlink="http://www.w3.org/1999/xlink" xsi:schemaLocation="urn:mpeg:dash:schema:mpd:2011 DASH-MPD.xsd" xmlns:cenc="urn:mpeg:cenc:2013" profiles="urn:mpeg:dash:profile:isoff-live:2011" minBufferTime="PT3.2S" type="dynamic" publishTime="2018-04-04T19:07:56Z" availabilityStartTime="2018-04-04T12:29:53Z" minimumUpdatePeriod="PT5S" timeShiftBufferDepth="PT15000S" suggestedPresentationDelay="PT5S">
  <Period id="0" start="PT0S">
    <AdaptationSet id="0" contentType="video" maxWidth="1920" maxHeight="1080" frameRate="90000/3600" segmentAlignment="true" par="16:9">
      <Representation id="0" bandwidth="4000000" codecs="avc1.4d4028" mimeType="video/mp4" sar="1:1" width="1920" height="1080">
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_video_1920_1080.mp4" media="video_1920_1080/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2776">
          <SegmentTimeline>
            <S t="799502400" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
      <Representation id="1" bandwidth="2500000" codecs="avc1.4d401f" mimeType="video/mp4" sar="1:1" width="1280" height="720">
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_video_1280_720.mp4" media="video_1280_720/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2776">
          <SegmentTimeline>
            <S t="799502400" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
      <Representation id="2" bandwidth="1000000" codecs="avc1.4d401e" mimeType="video/mp4" sar="82:81" width="720" height="410">
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_video_720_410.mp4" media="video_720_410/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2776">
          <SegmentTimeline>
            <S t="799502400" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
      <Representation id="7" bandwidth="700000" codecs="avc1.4d401e" mimeType="video/mp4" sar="1:1" width="640" height="360">
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_video_640_360.mp4" media="video_640_360/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2776">
          <SegmentTimeline>
            <S t="799502400" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
    </AdaptationSet>
    <AdaptationSet id="1" contentType="audio" lang="cs" segmentAlignment="true">
      <Representation id="3" bandwidth="130352" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="48000">
        <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/>
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_audio_cs.mp4" media="audio_cs/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2777">
          <SegmentTimeline>
            <S t="799489200" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
    </AdaptationSet>
    <AdaptationSet id="2" contentType="audio" lang="hu" segmentAlignment="true">
      <Representation id="4" bandwidth="130242" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="48000">
        <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/>
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_audio_hu.mp4" media="audio_hu/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2777">
          <SegmentTimeline>
            <S t="799489200" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
    </AdaptationSet>
    <AdaptationSet id="3" contentType="audio" lang="ro" segmentAlignment="true">
      <Representation id="5" bandwidth="130333" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="48000">
        <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/>
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_audio_ro.mp4" media="audio_ro/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2777">
          <SegmentTimeline>
            <S t="799489200" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
    </AdaptationSet>
    <AdaptationSet id="4" contentType="audio" lang="en" segmentAlignment="true">
      <Representation id="6" bandwidth="130364" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="48000">
        <AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/>
        <SegmentTemplate timescale="90000" initialization="eurosport-1-hd-test-52_audio_en.mp4" media="audio_en/eurosport-1-hd-test-52-$Number$.mp4" startNumber="2777">
          <SegmentTimeline>
            <S t="799489200" d="288000" r="4688"/>
          </SegmentTimeline>
        </SegmentTemplate>
      </Representation>
    </AdaptationSet>
  </Period>
</MPD>

@kqyang
Copy link
Contributor

kqyang commented Apr 4, 2018

Emm... That looks like a bug.

From #370, it seems to be working if you use the 3-character code and it only fails if you are using the two-character code. Is that what you observed?

We'll look into it.

@kqyang kqyang added the type: bug Something isn't working correctly label Apr 4, 2018
@jakubvojacek
Copy link
Author

yes, I have noticed the same. Thank you

@kqyang kqyang added this to the v2.1 milestone Apr 5, 2018
@kqyang kqyang self-assigned this Apr 5, 2018
kqyang added a commit that referenced this issue Apr 20, 2018
Two-character ISO-639 code in --default_language was ignored due to
a bug in language code matching as the language code in stream is
always converted to 3-character code.

Fixes #371.

Change-Id: I8618938af583a417446636ff9efe1c72ce822c33
@kqyang
Copy link
Contributor

kqyang commented Apr 20, 2018

Cherry-picked for v2.0.3.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 12, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants