Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Removal of "wvtt" from CODEC #402

Closed
cgp1081 opened this issue May 29, 2018 · 6 comments
Closed

Allow Removal of "wvtt" from CODEC #402

cgp1081 opened this issue May 29, 2018 · 6 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Milestone

Comments

@cgp1081
Copy link

cgp1081 commented May 29, 2018

System info

Gen 3 AppleTV Devices

Though WebVTT captions are supported on these devices, content with "wvtt" in the CODEC: of #EXT-X-STREAM-INF: will not play on these devices. Content playback error is given.

When "wvtt" is removed, content loads normally and WebVTT captions found in #EXT-X-MEDIA:TYPE=SUBTITLES work as expected.

Per HLS guidelines wvtt is optional and its exclusion will allow content to play correctly w/WebVTT captions on all Apple devices
https://developer.apple.com/library/content/documentation/General/Reference/HLSAuthoringSpec/Requirements.html
5.10. The kind of subtitles SHOULD be specified in the CODECS attribute of the associated EXT-X-STREAM-INF tags. You SHOULD use “stpp.ttml.im1t” to identify IMSC1 subtitles. You MAY use “wvtt" to identify WebVTT subtitles.

@cgp1081 cgp1081 changed the title Remove ".vtt" from CODEC Allow Removal of ".wvtt" from CODEC May 29, 2018
@vaage
Copy link
Contributor

vaage commented May 29, 2018

@cgp1081 Could you try changing it to be "wvtt" instead of ".wvtt"? It may just be that we have an off-by-one substring problem and are actually adding an invalid codec type (".wvtt" instead of "wvtt").

@cgp1081
Copy link
Author

cgp1081 commented May 29, 2018

Let me update the original post, it is already "wvtt'

#EXT-X-STREAM-INF:BANDWIDTH=6016584,CODECS="avc1.640028,mp4a.40.2,wvtt"

@cgp1081 cgp1081 changed the title Allow Removal of ".wvtt" from CODEC Allow Removal of "wvtt" from CODEC May 29, 2018
@vaage
Copy link
Contributor

vaage commented May 29, 2018

@kqyang How would you like to handle this. What we are doing is not against spec. This sounds more like a player problem than a packaging problem.

@cgp1081
Copy link
Author

cgp1081 commented May 29, 2018

@vaage I do agree that its a player issue, but Apple likely won't be updating firmware on these older pre-tvOS devices - which unfortunately still have a significant amount of users. The only way to get streams to play there is by removing the vtt.

@kqyang
Copy link
Contributor

kqyang commented May 29, 2018

I agree with @cgp1081. It is an Apple platform issue, but unfortunately we do not have control over the Apple platform. I agree that the best solution is to workaround it in packager.

@kqyang kqyang added this to the v2.2 milestone May 29, 2018
@kqyang kqyang added type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking and removed needs triage labels May 29, 2018
@kqyang
Copy link
Contributor

kqyang commented Jun 29, 2018

Cherry-picked to v2.1.1.

kqyang pushed a commit that referenced this issue Jun 29, 2018
Having "wvtt" in the codec string (in the master playlist) causes
errors on some older Apple products. As including it is optional,
we are opted to omit it to ensure support for all Apple products.

Close #402

Change-Id: Ib1072bcc26a3ff66e3a6d3204789c0c8c678d4db
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Aug 19, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly type: external An issue with an external dependency; not our issue; sometimes kept open for tracking
Projects
None yet
Development

No branches or pull requests

4 participants