Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebM] Sample decoding time stamp is always set to 0 #67

Closed
kqyang opened this issue Jan 20, 2016 · 1 comment
Closed

[WebM] Sample decoding time stamp is always set to 0 #67

kqyang opened this issue Jan 20, 2016 · 1 comment
Assignees
@kqyang
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly

Comments

@kqyang
Copy link
Contributor

kqyang commented Jan 20, 2016

The bug is introduced in v1.3.0 with WebM support.

It does not affect WebM packaging, since presentation timestamp and decoding timestamp are the same. However, if we want to package into ISO-BMFF (mp4) container, the decoding timestamp is not set correctly.
@kqyang kqyang added the type: bug Something isn't working correctly label Jan 20, 2016
@kqyang kqyang self-assigned this Jan 20, 2016
kqyang added a commit that referenced this issue Jan 21, 2016
@kqyang
WebMParser: set duration and dts correctly
940c357 
- dts was not set earlier, although for WebM, we could assume that
  dts is the same as pts.
- Calculate block duration with the difference with the next block
  if duration is not encoded, even if track default_duration is set.
- Use track default_duration as a duration estimate for the last
  block.
- This also removes opus duration computation from encoded data.

Issues #67, #68

Change-Id: Icaa2769dcb2a89269ae014f44ad6a9262770aed2
@kqyang
Copy link
Contributor Author

kqyang commented Jan 22, 2016

Fixed.

@kqyang kqyang closed this as completed Jan 22, 2016
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 19, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kqyang kqyang

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kqyang @shaka-bot