Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PTS diverge DTS when DTS close to 2pow33 and PTS more than 0 #1050

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix: PTS diverge DTS when DTS close to 2pow33 and PTS more than 0 #1050

merged 2 commits into from
Oct 27, 2022

Conversation

zdanek
Copy link
Contributor

@zdanek zdanek commented Mar 17, 2022

Fixes #1049

@zdanek zdanek mentioned this pull request Mar 17, 2022
Closed
@zdanek zdanek changed the title Fix DTS pass 2pow33 when PTS more than 0 fix: PTS diverge DTS when DTS close to 2pow33 and PTS more than 0 Mar 17, 2022
joeyparrish
joeyparrish requested changes Oct 27, 2022
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. I'll make a quick correction to the test comment and merge it.

packager/media/formats/mp2t/mp2t_media_parser_unittest.cc Show resolved Hide resolved
@joeyparrish joeyparrish merged commit ab8ab12 into shaka-project:main Oct 27, 2022
@zdanek
Copy link
Contributor Author

zdanek commented Oct 28, 2022

Thank you.

sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
@zdanek @joeyparrish @sr1990
fix: PTS diverge DTS when DTS close to 2pow33 and PTS more than 0 (sh…
2c19730 
…aka-project#1050)

Fixes shaka-project#1049

Co-authored-by: Joey Parrish <[email protected]>
sr1990 pushed a commit to sr1990/shaka-packager that referenced this pull request Feb 18, 2023
@zdanek @joeyparrish @sr1990
fix: PTS diverge DTS when DTS close to 2pow33 and PTS more than 0 (sh…
1560525 
…aka-project#1050)

Fixes shaka-project#1049

Co-authored-by: Joey Parrish <[email protected]>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MPEGTS] Special case when unrolled DTS and PTS diverge
2 participants
@zdanek @joeyparrish