feat: Add xHE-AAC support #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: * An xHE-AAC capable encoder will auto adjust the user-specified SAP/RAP value to the allowed grid where SAP/RAPs can occur. e.g.: `-rapInterval 5000` (5s) may result in actual SAPs/RAPs every 4.984s. * To ensure SAP/RAP starts a new segment, Shaka needs to executed with a "--segment_duration" is less than or equal to that adjusted value. * If every SAP/RAP should trigger a new segment, just set the segment length to a very low value e.g.: `--segment_duration 0.1`
Closed
|
I verified that this patch does package xhe-aac sample files from https://www2.iis.fraunhofer.de/AAC/xhe-aac-abr.html whereas without this patch the packaging errors. |
joeyparrish
requested changes
Sep 7, 2022
Note: * An xHE-AAC capable encoder will auto adjust the user-specified SAP/RAP value to the allowed grid where SAP/RAPs can occur. e.g.: `-rapInterval 5000` (5s) may result in actual SAPs/RAPs every 4.984s. * To ensure SAP/RAP starts a new segment, Shaka needs to executed with a "--segment_duration" is less than or equal to that adjusted value. * If every SAP/RAP should trigger a new segment, just set the segment length to a very low value e.g.: `--segment_duration 0.1`
|
@joeyparrish Did the changes come through. TBH I've not often contributed to projects, and so I'm not sure I did it correctly. |
|
@joeyparrish Apologies for bugging you. Is there a timeline for when this might get merged (assuming it's acceptable)? I have a downstream vendor that depends on the Shaka packager, and we can't use their service until it has xHE-AAC support. |
|
It does look like the requested changes have been addressed. +1 for merging this. |
|
@joeyparrish Feedback from a downstream application that uses Shaka Packager is that it works for them, but they are unable to merge the patch with their code until this PR is merged. |
|
Apologies for dropping this. I'll review tomorrow (Tuesday, US/Pacific time). |
joeyparrish
approved these changes
Oct 18, 2022
joeyparrish
pushed a commit
that referenced
this pull request
Oct 18, 2022
Note: * An xHE-AAC capable encoder will auto adjust the user-specified SAP/RAP value to the allowed grid where SAP/RAPs can occur. e.g.: `-rapInterval 5000` (5s) may result in actual SAPs/RAPs every 4.984s. * To ensure SAP/RAP starts a new segment, Shaka needs to executed with a "--segment_duration" is less than or equal to that adjusted value. * If every SAP/RAP should trigger a new segment, just set the segment length to a very low value e.g.: `--segment_duration 0.1`
sr1990
pushed a commit
to sr1990/shaka-packager
that referenced
this pull request
Feb 18, 2023
Note: * An xHE-AAC capable encoder will auto adjust the user-specified SAP/RAP value to the allowed grid where SAP/RAPs can occur. e.g.: `-rapInterval 5000` (5s) may result in actual SAPs/RAPs every 4.984s. * To ensure SAP/RAP starts a new segment, Shaka needs to executed with a "--segment_duration" is less than or equal to that adjusted value. * If every SAP/RAP should trigger a new segment, just set the segment length to a very low value e.g.: `--segment_duration 0.1`
sr1990
pushed a commit
to sr1990/shaka-packager
that referenced
this pull request
Feb 18, 2023
Note: * An xHE-AAC capable encoder will auto adjust the user-specified SAP/RAP value to the allowed grid where SAP/RAPs can occur. e.g.: `-rapInterval 5000` (5s) may result in actual SAPs/RAPs every 4.984s. * To ensure SAP/RAP starts a new segment, Shaka needs to executed with a "--segment_duration" is less than or equal to that adjusted value. * If every SAP/RAP should trigger a new segment, just set the segment length to a very low value e.g.: `--segment_duration 0.1`
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
value to the allowed grid where SAP/RAPs can occur.
e.g.:
-rapInterval 5000(5s) may result in actual SAPs/RAPs every 4.984s."--segment_duration" is less than or equal to that adjusted value.
length to a very low value e.g.:
--segment_duration 0.1