fix: Fix handling of non-interleaved multi track FMP4 files #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
changed the title
joeyparrish
requested changes
Jul 5, 2023
There was a problem hiding this comment.
@duggaraju, could you add a unit test of some kind for this?
joeyparrish
added
the
status: waiting on response
|
The fix looks good otherwise. Thanks for contributing! |
|
Thnaks. Let me take a shot at the unit tests and update the PR. |
|
Added a simple unit tests. |
github-actions
bot
removed
the
status: waiting on response
joeyparrish
approved these changes
Jul 25, 2023
|
It seems that the tests crash with an out-of-bounds index. Please fix the tests! |
joeyparrish
requested changes
Jul 26, 2023
Donot assume that each fragment contains all tracks. Use track id instead of index to pick the correct timestamp.
|
@joeyparrish let me know if the changes look ok. |
|
assuming the tests pass this looks good to me |
cosmin
approved these changes
Aug 2, 2023
|
@joeyparrish any concerns? |
|
Looks good to me |
joeyparrish
approved these changes
Aug 21, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not assume that each fragment contains all tracks.
Use track id instead of index to pick the correct timestamp.
Fixes #1213