fix: Fix failure on very short WebVTT files #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne block:
WEBVTT
00:00:00.500 --> 00:00:02.000
The Web is always changing
shaka packager will report error: "Packaging Error: 6 (END_OF_STREAM)".
Fix:
In Demuxer::InitializeParser(), if eof is reaching, invoke parser_->Flush() to
flash the parser.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
joeyparrish
approved these changes
Jul 5, 2023
joeyparrish
changed the title
joeyparrish
requested changes
Jul 5, 2023
There was a problem hiding this comment.
@xieyubo, there are a bunch of test failures. Please fix these.
joeyparrish
added
the
status: waiting on response
|
I believe the test failures on Linux are those fixed by #1226, and the Windows and Mac failures are aging build systems and scripts which are all being replaced in the |
joeyparrish
removed
the
status: waiting on response
joeyparrish
approved these changes
Jul 12, 2023
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that if the webvtt file is very short, e.g. only contains one block
shaka packager will report error: "Packaging Error: 6 (END_OF_STREAM)".
Fixes #1217