Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing <cstdint> includes #1306

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

modernletter
Copy link
Contributor

CC version 13 needs <cstdint> to be explicitly included to
provide fixed bits integer types.

Some files using it inludes <stdint.h>, some are missing direct or undirect inclusion. This PR adds <cstdint> inclusion to the
minimal set of files, allowing compilation on GCC 13.

Closes #1305

GCC version 13 needs <cstdint> to be explicitly included to
provide fixed bits integer types. Some files using it inludes
<stdint.h>, this commit adds <cstdint> inclusion to the
missing ones and it's needed to compile project on GCC 13.

Source: https://gcc.gnu.org/gcc-13/porting_to.html
@cosmin cosmin merged commit ba5c771 into shaka-project:main Nov 30, 2023
11 of 20 checks passed
@modernletter modernletter deleted the gcc13 branch November 30, 2023 13:54
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build shaka-packager with GCC 13- missing stdint fixed bits integer types
2 participants