Skip to content

Commit

Permalink
fix: Remove IE 11 from default browsers for Windows (#4272)
Browse files Browse the repository at this point in the history
IE 11 has not been supported since v3.1, so developers following
CONTRIBUTING.md should not see tests fail due to the continued inclusion
of IE. Removed IE from the default list of browsers for Windows. Anybody
who still needs to test against IE can explicitly test via python
build/test.py --browsers IE.

Closes #4271
  • Loading branch information
RaymondCheng authored and Alvaro Velad committed Jun 14, 2022
1 parent f497135 commit 1e83080
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,4 @@ Verizon Digital Media Services <*@verizondigitalmedia.com>
ViacomCBS <*@viacomcbs.com>
Vincent Valot <[email protected]>
Wayne Morgan <[email protected]>
Raymond Cheng <[email protected]>
1 change: 1 addition & 0 deletions CONTRIBUTORS
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,4 @@ Vignesh Venkatasubramanian <[email protected]>
Vincent Valot <[email protected]>
Wayne Morgan <[email protected]>
Yohann Connell <[email protected]>
Raymond Cheng <[email protected]>
2 changes: 1 addition & 1 deletion build/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def _GetDefaultBrowsers():
return ['Chrome','Edge','Firefox','Safari']

if shakaBuildHelpers.is_windows() or shakaBuildHelpers.is_cygwin():
return ['Chrome','Edge','Firefox','IE']
return ['Chrome','Edge','Firefox']

raise Error('Unrecognized system: %s' % platform.uname()[0])

Expand Down

0 comments on commit 1e83080

Please sign in to comment.