Add detail to video errors in Chrome

This makes use of a new field added to Chrome 59.

Change-Id: I1b68e803967cfd7cfb64cea26458d0f3ef8a27c1

externs/mediaerror.js

@@ -0,0 +1,38 @@
+/**
+ * @license
+ * Copyright 2016 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+
+/**
+ * @fileoverview Externs for MediaError properties not in the Closure compiler.
+ *
+ * @externs
+ */
+
+
+/**
+ * A new field in the living standard to give a more informative diagnostic
+ * message about the error.
+ * @type {string}
+ */
+MediaError.prototype.message;
+
+
+/**
+ * A Microsoft Edge & IE extension to add a Windows error code.
+ * @type {number}
+ */
+MediaError.prototype.msExtendedCode;

externs/msmediakeys.js

@@ -124,7 +124,3 @@ MSMediaKeyError.MS_MEDIA_KEYERR_HARDWARECHANGE;
 
 /** @type {number} */
 MSMediaKeyError.MS_MEDIA_KEYERR_DOMAIN;
-
-
-/** @type {number} */
-MediaError.prototype.msExtendedCode;

lib/player.js

@@ -2558,11 +2558,14 @@ shaka.Player.prototype.onVideoError_ = function(event) {
     extended = extended.toString(16);
   }
 
+  // Extra error information from Chrome:
+  var message = this.video_.error.message;
+
   this.onError_(new shaka.util.Error(
       shaka.util.Error.Severity.CRITICAL,
       shaka.util.Error.Category.MEDIA,
       shaka.util.Error.Code.VIDEO_ERROR,
-      code, extended));
+      code, extended, message));
 };
 
 

lib/util/error.js

@@ -365,6 +365,7 @@ shaka.util.Error.Code = {
    * The video element reported an error.
    * <br> error.data[0] is a MediaError code from the video element.
    * <br> On Edge & IE, error.data[1] is a Microsoft extended error code in hex.
+   * <br> On Chrome, error.data[2] is a string with details on the error.
    */
   'VIDEO_ERROR': 3016,