Skip to content

Commit

Permalink
Correct Subtitle/Caption in Externs
Browse files Browse the repository at this point in the history
In externs we used the working "subtitles" and "caoptions" but in
the code we use "subtitle" and "caption". This changes all
references to "subtitles" and "captions" in externs to be "subtitle"
and "caption".

Closes #808

Change-Id: I58b5cb3b5f5533af3c856cd32504d6b3620aee9a
  • Loading branch information
vaage committed May 16, 2017
1 parent 494d608 commit 76ec545
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion externs/shaka/manifest.js
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ shakaExtern.GetSegmentReferenceFunction;
* The stream's height in pixels.
* @property {(string|undefined)} kind
* <i>Text streams only.</i> <br>
* The kind of text stream. For example, 'captions' or 'subtitles'.
* The kind of text stream. For example, 'caption' or 'subtitle'.
* @see https://goo.gl/k1HWA6
* @property {boolean} encrypted
* <i>Defaults to false.</i><br>
Expand Down
4 changes: 2 additions & 2 deletions externs/shaka/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,8 @@ shakaExtern.Stats;
* The language of the track, or 'und' if not given. This is the exact
* value provided in the manifest; it may need to be normalized.
* @property {?string} kind
* (only for text tracks) The kind of text track, either 'captions' or
* 'subtitles'.
* (only for text tracks) The kind of text track, either 'caption' or
* 'subtitle'.
* @property {?number} width
* The video width provided in the manifest, if present.
* @property {?number} height
Expand Down

0 comments on commit 76ec545

Please sign in to comment.