Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event needed between manifest parsing and the start of streaming #1043

Closed
joeyparrish opened this issue Oct 2, 2017 · 3 comments
Closed

Event needed between manifest parsing and the start of streaming #1043

joeyparrish opened this issue Oct 2, 2017 · 3 comments
Assignees
@michellezhuogg
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.3.0

Comments

@joeyparrish
Copy link
Member

@chrisfillmore writes in #1029 (comment):

We have a scenario where we need to know the bandwidth levels from the manifest before we start playback, so that we can set the max bandwidth in order to restrict certain variants.

It sounds like we need a hook or event to examine content metadata between manifest parsing and the start of streaming.

The only tricky bit is to make sure that the event is dispatched in a synchronous way at the right point. I think this should be after filtering based on MSE & EME, and after Track info is available, but before an initial track selection is made by AbrManager. That will allow restrictions to be set before any segment requests are made.
@joeyparrish joeyparrish added flag: good first issue This might be a relatively easy issue; good for new contributors type: enhancement New feature or request labels Oct 2, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Oct 2, 2017
This was referenced Oct 2, 2017
Closed
Closed
@chrisfillmore
Copy link
Contributor

Ooh, very nice. We would need to know bandwidth and codec information. Thanks Joey.

@joeyparrish
Copy link
Member Author

That should all be available from shakaExtern.Track. Let us know if there's anything missing!

joeyparrish pushed a commit that referenced this issue Nov 1, 2017
@michellezhuogg @joeyparrish
Add Streaming Event and Manifest Getter Method
454d366 
Adding an event right after the player parses the manifest, and before
initiating streaming, so that users can get the manifest information.
Adding manifest getter method in player so that customers can access
manifest information.

Closes #1043
Closes #1074
Issue #1036

Change-Id: I0016c312bacdfa86299e5df68b586f90d565cfdc
@joeyparrish
Copy link
Member Author

New method cherry-picked for v2.2.5.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellezhuogg michellezhuogg

Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
4 participants
@joeyparrish @chrisfillmore @shaka-bot @michellezhuogg