Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom build fails if @text is not included #1115

Closed
sdcooke opened this issue Nov 8, 2017 · 2 comments
Closed

Custom build fails if @text is not included #1115

sdcooke opened this issue Nov 8, 2017 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@sdcooke
Copy link

sdcooke commented Nov 8, 2017

When creating a custom build with the v2.2.5 tag the following happens:

$ python build.py +@dash +@networking +@polyfill
[INFO] Compiling the library...
/Users/sam/Development/open-source/shaka-player/lib/player.js:1996: ERROR - missing require: 'shaka.text.SimpleTextDisplayer'
      return new shaka.text.SimpleTextDisplayer(videoElement);
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The following works:

python build.py +@dash +@networking +@polyfill +@text

I would have expected @text to be optional.

I started modifying some files to see if it was a quick fix but just hit more code that relied on shaka.text.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 8, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Nov 8, 2017
@joeyparrish
Copy link
Member

Definitely seems like a bug. Any core (required) components related to text should be in the "core" list of sources, not "text".

@joeyparrish joeyparrish self-assigned this Nov 8, 2017
joeyparrish added a commit that referenced this issue Nov 13, 2017
This allows optional text plugins to be excluded from the build.

Closes #1115

Change-Id: I500afe51191ec224e9bad672f76c908fdf38abcb
@joeyparrish
Copy link
Member

Fix cherry-picked to v2.2.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants