Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DrmInfo callbacks fail to compare if they are closures or bound #227

Closed
joeyparrish opened this issue Nov 5, 2015 · 1 comment
Closed

DrmInfo callbacks fail to compare if they are closures or bound #227

joeyparrish opened this issue Nov 5, 2015 · 1 comment
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v1.6.0

Comments

@joeyparrish
Copy link
Member

If your app's ContentProtection callback returns multiple DrmInfos with callbacks which are either closures or bound separately on each callback invocation, these callbacks don't compare as equal to each other.

This bug affects v1.5.0 and v1.5.1.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Nov 5, 2015
@joeyparrish joeyparrish self-assigned this Nov 5, 2015
@joeyparrish joeyparrish added this to the v1.6.0 milestone Nov 5, 2015
@joeyparrish
Copy link
Member Author

Fixed in 6263e1f.

@joeyparrish joeyparrish mentioned this issue Nov 5, 2015
Closed
joeyparrish added a commit that referenced this issue Nov 11, 2015
@joeyparrish
Avoid comparison of callback methods in DrmInfo
12ad283 
A partial cherry-pick of 'Add support for YT PlayReady test content'
from master.

Issue #227
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v1.6.0
Development

No branches or pull requests
3 participants
@TheModMaker @joeyparrish @shaka-bot