Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with non-linear IMA CS ads #2596

Closed
jakubvojacek opened this issue May 28, 2020 · 2 comments · Fixed by #3639
Closed

Integrate with non-linear IMA CS ads #2596

jakubvojacek opened this issue May 28, 2020 · 2 comments · Fixed by #3639
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@jakubvojacek
Copy link

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
nigthly master demo

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
your nightly demo

If custom app, can you reproduce the issue using our demo app?
yes

What browser and OS are you using?
MacOS + Chrome

What are the manifest and license server URIs?
Big bunny video from your demo + IMA SDK sample tag from page https://developers.google.com/interactive-media-ads/docs/sdks/html5/tags called Single Non-linear Inline (I believe those links expire after some time so Im not sharing link directly to the VMAP)

What did you do?
Attempted to play the custom clear dash content with given ad url

What did you expect to happen?
that the non linear image would be displayed and the video would start in the background

What actually happened?
the ad was displayed but the video never started (and the controls are hidden behind the banner)

@joeyparrish joeyparrish added component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs needs triage labels May 28, 2020
@ismena
Copy link
Contributor

ismena commented May 28, 2020

Hi @jakubvojacek
Thanks for the report! We are only launching linear ads with our upcoming release, so I'm converting this issue to a feature request.

I will prioritize this work now that I know that real people are using this functionality!
If there are any other ad types/requests that are a priority to you, please feel free to also let us know, we will schedule accordingly.

@ismena ismena changed the title Non linear ads are not working properly (video never starts) Integrate with non-linear IMA CS ads May 28, 2020
@ismena ismena added type: enhancement New feature or request and removed needs triage labels May 28, 2020
@jakubvojacek
Copy link
Author

Thank you @ismena. We're planning to launch with linear, nonlinear and surveys (already discussed in another issue), targeted platforms are android (exoplayer), web and ios (via shaka player embedded).

So far we're havent found any issues with linear ads but were just in the process of creating our ad manager and creating our own vmap xmls. In case we run into more issues, I will open a ticket

Once again thank you

@shaka-bot shaka-bot added this to the Backlog milestone May 28, 2020
@joeyparrish joeyparrish added the priority: P2 Smaller impact or easy workaround label Sep 29, 2021
theodab pushed a commit that referenced this issue Oct 18, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 17, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Dec 17, 2021
@avelad avelad modified the milestones: Backlog, v3.3 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants