Inconsistent license headers #2638
Assignees
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
|
I believe this is related to the compiler upgrade we did in the v3.0 release cycle. |
|
Not having a license header in the generated externs is also causing us some grief pushing v3.0.0 through some internal systems. So that should be fixed, too. |
shaka-bot
pushed a commit
that referenced
this issue
Jun 10, 2020
The block comment syntax "/*!" is used to force a license header to appear in the output of the Closure Compiler and other tools, but we need eslint to allow it. Issue #2638 Change-Id: I7a461ba0ffcdbdd588dbe60ca5629b5ccbdf2fed
shaka-bot
pushed a commit
that referenced
this issue
Jun 10, 2020
This fixes all the license headers in the main library, which corrects the appearance of the main license in the compiled output. It seems that the `!` in the header forces the compiler to keep it in the output. I believe older compiler releases did this purely based on `@license`. Issue #2638 Change-Id: I7f0e918caad10c9af689c9d07672b7fe9be7b2f3
shaka-bot
pushed a commit
that referenced
this issue
Jun 10, 2020
Though not part of the library, this corrects/normalizes the license headers in the demo app to be consistent with those in the library. Issue #2638 Change-Id: I4546c4c6970d72ff71a37489fd582623bd6e2ca3
shaka-bot
pushed a commit
that referenced
this issue
Jun 10, 2020
This corrects/normalizes license headers in misc. files, such as config files, docs, build tools, tests, and externs. This does not affect the compiled output, and is only done for consistency. Issue #2638 Change-Id: I9d8da2de55243b08d7df2b743aac73c6f15e858a
shaka-bot
pushed a commit
that referenced
this issue
Jun 10, 2020
This forces the inclusion of the following license headers from third-party code: - language-mapping-list (Copyright 2013 Ali Al Dallal) - goog-uri (Copyright 2006 & 2008 The Closure Library Authors) The Closure headers have been shortened, since they use the same Apache-2.0 license as Shaka Player. The other license has been left in its full form. Issue #2638 Change-Id: Idea7c0f2cb9eb8039eeb3f64fe5cc27e7cb78006
shaka-bot
pushed a commit
that referenced
this issue
Jun 10, 2020
This corrects/normalizes the license headers in CSS and LESS files. The LESS tool respects the same "/*!" syntax for forcing the inclusion of a license header, but will not dedup these licenses. So the LESS files generally will not use this syntax. Instead, the build system prepends a license header after compilation. The exception is for our SVG spinner, which is based on third-party CSS from codepen. The copyright header for this is forced into the output to give proper credit to the original author. Issue #2638 Change-Id: I4c58e2b082f2d5e550a6f0a30feaaf9ebf82a53a
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
The block comment syntax "/*!" is used to force a license header to appear in the output of the Closure Compiler and other tools, but we need eslint to allow it. Issue #2638 Change-Id: I7a461ba0ffcdbdd588dbe60ca5629b5ccbdf2fed
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
This fixes all the license headers in the main library, which corrects the appearance of the main license in the compiled output. It seems that the `!` in the header forces the compiler to keep it in the output. I believe older compiler releases did this purely based on `@license`. Issue #2638 Change-Id: I7f0e918caad10c9af689c9d07672b7fe9be7b2f3
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
Though not part of the library, this corrects/normalizes the license headers in the demo app to be consistent with those in the library. Issue #2638 Change-Id: I4546c4c6970d72ff71a37489fd582623bd6e2ca3
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
This corrects/normalizes license headers in misc. files, such as config files, docs, build tools, tests, and externs. This does not affect the compiled output, and is only done for consistency. Issue #2638 Change-Id: I9d8da2de55243b08d7df2b743aac73c6f15e858a
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
This forces the inclusion of the following license headers from third-party code: - language-mapping-list (Copyright 2013 Ali Al Dallal) - goog-uri (Copyright 2006 & 2008 The Closure Library Authors) The Closure headers have been shortened, since they use the same Apache-2.0 license as Shaka Player. The other license has been left in its full form. Issue #2638 Change-Id: Idea7c0f2cb9eb8039eeb3f64fe5cc27e7cb78006
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
This corrects/normalizes the license headers in CSS and LESS files. The LESS tool respects the same "/*!" syntax for forcing the inclusion of a license header, but will not dedup these licenses. So the LESS files generally will not use this syntax. Instead, the build system prepends a license header after compilation. The exception is for our SVG spinner, which is based on third-party CSS from codepen. The copyright header for this is forced into the output to give proper credit to the original author. Issue #2638 Change-Id: I4c58e2b082f2d5e550a6f0a30feaaf9ebf82a53a
joeyparrish
added a commit
that referenced
this issue
Jun 10, 2020
To comply with internal regulations, even our generated externs should have a license header. This prepends the header to all generated externs. Closes #2638 Change-Id: Idef8e7bff53363175aefa34274a8f71477e830fa
joeyparrish
added a commit
that referenced
this issue
Jun 11, 2020
The block comment syntax "/*!" is used to force a license header to appear in the output of the Closure Compiler and other tools, but we need eslint to allow it. Issue #2638 Backported to v2.5.x Change-Id: I7a461ba0ffcdbdd588dbe60ca5629b5ccbdf2fed
joeyparrish
added a commit
that referenced
this issue
Jun 11, 2020
It seems that the `!` in the header forces the compiler to keep it in the output. I believe older compiler releases did this purely based on `@license`. Issue #2638 This is a minimal backport to v2.5.x which only touches the compiled wrapper. Change-Id: I7f0e918caad10c9af689c9d07672b7fe9be7b2f3
joeyparrish
added a commit
that referenced
this issue
Jun 11, 2020
This forces the inclusion of the following license headers from third-party code: - language-mapping-list (Copyright 2013 Ali Al Dallal) - goog-uri (Copyright 2006 & 2008 The Closure Library Authors) The Closure headers have been shortened, since they use the same Apache-2.0 license as Shaka Player. The other license has been left in its full form. Issue #2638 Change-Id: Idea7c0f2cb9eb8039eeb3f64fe5cc27e7cb78006
joeyparrish
added a commit
that referenced
this issue
Jun 11, 2020
The LESS tool respects the same "/*!" syntax for forcing the inclusion of a license header, but will not dedup these licenses. So the LESS files generally will not use this syntax. Instead, the build system prepends a license header after compilation. The exception is for our SVG spinner, which is based on third-party CSS from codepen. The copyright header for this is forced into the output to give proper credit to the original author. Issue #2638 This is a minimal backport to v2.5.x which only touches the header in the output. Change-Id: I4c58e2b082f2d5e550a6f0a30feaaf9ebf82a53a
joeyparrish
added a commit
that referenced
this issue
Jun 11, 2020
To comply with internal regulations, even our generated externs should have a license header. This prepends the header to all generated externs. Closes #2638 Change-Id: Idef8e7bff53363175aefa34274a8f71477e830fa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v3.0.0
Can you reproduce the issue with our latest release version?
yes
Can you reproduce the issue with the latest code from
master?yes
Are you using the demo app or your own custom app?
N/A
What browser and OS are you using?
N/A
What are the manifest and license server URIs?
N/A
What did you do?
Build Shaka Player
What did you expect to happen?
License headers should appear consistently in the compiled output
What actually happened?
A license header for the Closure Library and our EME encryption scheme polyfill both appear in the output, but the main license does not.
The text was updated successfully, but these errors were encountered: