Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrickMode doesn't eliminate representations which use incompatible codecs #2846

Closed
jhnbwrs opened this issue Sep 11, 2020 · 1 comment · Fixed by #2984
Closed

TrickMode doesn't eliminate representations which use incompatible codecs #2846

jhnbwrs opened this issue Sep 11, 2020 · 1 comment · Fixed by #2984
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@jhnbwrs
Copy link

jhnbwrs commented Sep 11, 2020

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?

v3.1.0-pre (uncompiled)

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from master?
yes

Are you using the demo app or your own custom app?
demo

If custom app, can you reproduce the issue using our demo app?
NA

What browser and OS are you using?
Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
NA

What are the manifest and license server URIs?

manifest:
https://content-ausw2-dt-man1.downlynk.com/34c2e8dc7078462a80fcf9c461ba0073.mpd?prettydash=1&ifo=1&vcodec=all
license server:
https://content-ausw2-dt-man1.downlynk.com/wv

What did you do?

Enable Trick mode controls and then enagage trick mode:

What did you expect to happen?
There are 2 trick mode adaptation sets one HEVC and one AVC -- There are also AVC and HEVC video representations. Shaka picks the video representation that it can play (avc) but then when you engage trick mode it appears to pick the HEVC trick mode representation.

What actually happened?

After engaging trick mode you get:

Shaka Error MEDIA.VIDEO_ERROR (3,,CHUNK_DEMUXER_ERROR_APPEND_FAILED: Append: stream parsing failed. Data size=854 append_window_start=0 append_window_end=434.794)

I can restrict the the codecs included in the manifest using url parameters to my manifest server, and if I simply remove the HEVC representations, trick mode will engage fine:

using:
"https://content-ausw2-dt-man1.downlynk.com/34c2e8dc7078462a80fcf9c461ba0073.mpd?prettydash=1&ifo=1&vcodec=avc"

and the same license server.

@TheModMaker TheModMaker added type: bug Something isn't working correctly and removed needs triage labels Oct 2, 2020
@shaka-bot shaka-bot added this to the v3.1 milestone Oct 2, 2020
@avelad
Copy link
Member

avelad commented Nov 12, 2020

I created a PR to resolve it: #2984

joeyparrish pushed a commit that referenced this issue Dec 14, 2020
Resolves: #2846

Backported to v2.5.x

Change-Id: Ic708cec867bc3c84f911c585a5000b21c92e55d5
@shaka-project shaka-project locked and limited conversation to collaborators Jan 12, 2021
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants