Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'emsg' boxes when playing HLS manifest with CMAF segments #3348

Closed
duggaraju opened this issue Apr 19, 2021 · 3 comments · Fixed by #3653
Closed

Support for 'emsg' boxes when playing HLS manifest with CMAF segments #3348

duggaraju opened this issue Apr 19, 2021 · 3 comments · Fixed by #3653
Labels
component: HLS The issue involves Apple's HLS manifest format flag: good first issue This might be a relatively easy issue; good for new contributors priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@duggaraju
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

For DASH the list of supported 'emsg' schemas specified in the DASH manifest. Any emsg box that belongs to a schema not in the list is ignored by the player. For HLS there is no such equivalent in the manifest. (Except for ID3).

If we can expose emsgSchemedIdUris as an optional array of schemes on shaka.extern.HlsManifestConfiguration that the user can set then the emsg events can be fired during HLS playback as well.

@joeyparrish
Copy link
Member

Alternately, we could have a boolean config that enables watching for and dispatching all emsg boxes, regardless of schema. Would that be easier to configure or more useful, or would you prefer to limit it to a list of known, expected schemas?

@joeyparrish joeyparrish added type: enhancement New feature or request flag: good first issue This might be a relatively easy issue; good for new contributors component: HLS The issue involves Apple's HLS manifest format and removed needs triage labels Apr 20, 2021
@shaka-bot shaka-bot added this to the Backlog milestone Apr 20, 2021
@duggaraju
Copy link
Contributor Author

A boolean config could work too. But it would need some plumbing since the check for the schema is done in streaming_engine.js while the filling of the emseSchmeIdUris is done under manifest parser. You would need some special value (instead of default null) to indicate all schemas.

@duggaraju
Copy link
Contributor Author

Thanks. You can close the issue.

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 11, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Dec 11, 2021
@avelad avelad modified the milestones: Backlog, v3.3 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: HLS The issue involves Apple's HLS manifest format flag: good first issue This might be a relatively easy issue; good for new contributors priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants