-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEDIA.BUFFER_READ_OUT_OF_BOUNDS error when CEA caption packets are empty #3608
Labels
status: archived
Archived and locked; will not be updated
Comments
Here is an sample video segment that exhibits this problem |
caridley
added a commit
to caridley/shaka-player
that referenced
this issue
Aug 30, 2021
… caption packets are empty Added check for empty caption packets in closed_caption_parser. Added a unit test that verifies the closed_caption_parser now works with a video segment that contains empty caption packets.
11 tasks
caridley
added a commit
to caridley/shaka-player
that referenced
this issue
Aug 25, 2022
… caption packets are empty Added check for empty caption packets in closed_caption_parser. Added a unit test that verifies the closed_caption_parser now works with a video segment that contains empty caption packets.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.1.2
the problem does not occur with Shaka 2.5.22
Can you reproduce the issue with our latest release version?
Have not tested but quite certain that the problem will occur since it occurs with 3.1.2 and current master.
Can you reproduce the issue with the latest code from
master
?Yes
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
No
What browser and OS are you using?
Chrome 92.0.4515.159 on Mac OS 10.15.7
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
We will provide sample content if needed.
What configuration are you using? What is the output of
player.getConfiguration()
?We will provide this if needed, but we have already diagnosed the root cause and have will submit an PR soon
What did you do?
Played one of our DASH VOD streams that contains some empty embedded CEA caption packets.
What did you expect to happen?
Player should continue playing the stream as it does with Shaka 2.5.22
What actually happened?
This error is emitted and playback stops MEDIA.BUFFER_READ_OUT_OF_BOUNDS
This screen shot from devtools shows that the error originated in closed caption parsing code.
More specifically it occurs when CeaDecoder is passed an empty uint8ArrayData.
The text was updated successfully, but these errors were encountered: