Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UITextDisplayer test failing on Safari #3689

Closed
joeyparrish opened this issue Oct 8, 2021 · 0 comments
Closed

UITextDisplayer test failing on Safari #3689

joeyparrish opened this issue Oct 8, 2021 · 0 comments
Assignees
@theodab
Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: tests The issue involves our automated tests (generally; otherwise use a more specific component) component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v3.3

Comments

@joeyparrish
Copy link
Member

I suspect this is a timing issue, but a recently-added test for UITextDisplayer is failing on Safari.

Safari 14.1.1 (Mac OS 10.15.7) UITextDisplayer hides and shows nested cues at appropriate times FAILED
        Expected 'One' to be 'OneTwo'.
        <Jasmine>
        _callee9$@test/text/ui_text_displayer_unit.js:353:5 <- test/text/ui_text_displayer_unit.js:518:58
        tryCatch@node_modules/babel-polyfill/dist/polyfill.js:6900:44
        invoke@node_modules/babel-polyfill/dist/polyfill.js:7138:30
        step@test/text/ui_text_displayer_unit.js:3:191
        test/text/ui_text_displayer_unit.js:3:365
        <Jasmine>
        Expected 'One' to be 'TwoThree'.
        <Jasmine>
        _callee9$@test/text/ui_text_displayer_unit.js:359:5 <- test/text/ui_text_displayer_unit.js:527:58
        tryCatch@node_modules/babel-polyfill/dist/polyfill.js:6900:44
        invoke@node_modules/babel-polyfill/dist/polyfill.js:7138:30
        step@test/text/ui_text_displayer_unit.js:3:191
        test/text/ui_text_displayer_unit.js:3:365
        <Jasmine>
        Expected 'One' to be 'Three'.
        <Jasmine>
        _callee9$@test/text/ui_text_displayer_unit.js:365:5 <- test/text/ui_text_displayer_unit.js:536:58
        tryCatch@node_modules/babel-polyfill/dist/polyfill.js:6900:44
        invoke@node_modules/babel-polyfill/dist/polyfill.js:7138:30
        step@test/text/ui_text_displayer_unit.js:3:191
        test/text/ui_text_displayer_unit.js:3:365
        <Jasmine>
        Expected 1 to be 2.
        <Jasmine>
        _callee9$@test/text/ui_text_displayer_unit.js:370:5 <- test/text/ui_text_displayer_unit.js:544:50
        tryCatch@node_modules/babel-polyfill/dist/polyfill.js:6900:44
        invoke@node_modules/babel-polyfill/dist/polyfill.js:7138:30
        step@test/text/ui_text_displayer_unit.js:3:191
        test/text/ui_text_displayer_unit.js:3:365
        <Jasmine>
        Expected 'One' to be 'Three'.
        <Jasmine>
        _callee9$@test/text/ui_text_displayer_unit.js:371:5 <- test/text/ui_text_displayer_unit.js:545:58
        tryCatch@node_modules/babel-polyfill/dist/polyfill.js:6900:44
        invoke@node_modules/babel-polyfill/dist/polyfill.js:7138:30
        step@test/text/ui_text_displayer_unit.js:3:191
        test/text/ui_text_displayer_unit.js:3:365
        <Jasmine>
        TypeError: undefined is not an object (evaluating 'parentCueElements[1].textContent') in test/text/ui_text_displayer_unit.js (line 546)
        _callee9$@test/text/ui_text_displayer_unit.js:372:12 <- test/text/ui_text_displayer_unit.js:546:40
        tryCatch@node_modules/babel-polyfill/dist/polyfill.js:6900:44
        invoke@node_modules/babel-polyfill/dist/polyfill.js:7138:30
        step@test/text/ui_text_displayer_unit.js:3:191
        test/text/ui_text_displayer_unit.js:3:365
        <Jasmine>

Assigning to Theodore, who wrote the test earlier this week.
@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround browser: Safari Issues affecting Safari or WebKit derivatives component: tests The issue involves our automated tests (generally; otherwise use a more specific component) labels Oct 8, 2021
@shaka-bot shaka-bot added this to the v3.3 milestone Oct 8, 2021
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@theodab @joeyparrish
fix(text): Fix UI test failures
42f2db2 
A new UI test added in a recent CL involved manually setting the
currentTime value of a videoElement in tests.
For some reason that wasn't working on Safari, so this changes that
UI test to use a fake video instead of a real one.

Closes #3689

Change-Id: I412f677f6cda49bbfc850a9102edfe3b75bca302
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@theodab @joeyparrish
fix(text): Fix UI test failures
512064b 
A new UI test added in a recent CL involved manually setting the
currentTime value of a videoElement in tests.
For some reason that wasn't working on Safari, so this changes that
UI test to use a fake video instead of a real one.

Closes #3689

Change-Id: I412f677f6cda49bbfc850a9102edfe3b75bca302
joeyparrish pushed a commit that referenced this issue Oct 12, 2021
@theodab @joeyparrish
fix(text): Fix UI test failures
7a528c0 
A new UI test added in a recent CL involved manually setting the
currentTime value of a videoElement in tests.
For some reason that wasn't working on Safari, so this changes that
UI test to use a fake video instead of a real one.

Closes #3689

Change-Id: I412f677f6cda49bbfc850a9102edfe3b75bca302
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 8, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
browser: Safari Issues affecting Safari or WebKit derivatives component: tests The issue involves our automated tests (generally; otherwise use a more specific component) component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v3.3
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @theodab