Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With live streaming, shaka keeps refreshing previous manifest #369

Closed
aletorrado opened this issue May 5, 2016 · 4 comments
Closed

With live streaming, shaka keeps refreshing previous manifest #369

aletorrado opened this issue May 5, 2016 · 4 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@aletorrado
Copy link

After switching between different live streaming manifests using player.load('manifest.mpd'), shaka keeps fetching previous manifests indefinitely.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 6, 2016
@joeyparrish joeyparrish added this to the v2.0.0 milestone May 6, 2016
@tdrews
Copy link
Contributor

tdrews commented May 6, 2016

It could be a caching issue. What exact sequence of events are you following? E.g.,

  1. player.load('manifest.mpd');
  2. Pause video
  3. Change manifest.mpd
  4. player.load('manifest.mpd'); ?
    Does disabling the browser's cache work? (Network tab in Developer tools.)

Or do you mean that after calling player.load('manifest1.mpd') and then player.load('manifest2.mpd'), Shaka keeps fetching manifest1.mpd?

@aletorrado
Copy link
Author

Ok I got it. It's happening because on every player.load call, I'm doing this:

player.configure({
    abr: { manager: new shaka.abr.SimpleAbrManager() }
});

Now I'm doing abr.stop() on the previous abr instance to avoid this problem.

@tdrews
Copy link
Contributor

tdrews commented May 10, 2016

Ah, good catch. I see the problem in player.js now.

@tdrews tdrews self-assigned this May 12, 2016
shaka-bot pushed a commit that referenced this issue May 15, 2016
* Set this.parser_ to the correct property in load()
  (stops old manifests from being fetched).
* Stop load() from unloading first when the Player is a new instance.
* Handle multiple repeated calls to load().
* Fully cleanup after partial loads.
* Add additional destruction checks.

Issue #369

Change-Id: I43d5ed90c8119b1040b87a0dc187f52738e1c683
@joeyparrish
Copy link
Member

@aletorrado This should be fixed in master now. Please retest and let us know if the fix is working for you.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants