Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dash): Account for bandwidth before filtering text stream #3765

Merged
merged 4 commits into from
Mar 22, 2022
Merged

fix(dash): Account for bandwidth before filtering text stream #3765

merged 4 commits into from
Mar 22, 2022

Conversation

king-prawns
Copy link
Contributor

@king-prawns king-prawns commented Nov 22, 2021 •
edited
Loading

Description

Fixes #3724

Fix dedup stream logic adding bandwidth in the filterOutTextStreamDuplicates condition.

Another possible solution could be add the originalId in the all the filter conditions: #3725

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist:

  • I have signed the Google CLA https://cla.developers.google.com
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have verified my change on multiple browsers on different platforms
  • I have run ./build/all.py and the build passes
  • I have run ./build/test.py and all tests pass

This was referenced Nov 22, 2021
Closed
Closed
@avelad
Copy link
Member

avelad commented Mar 22, 2022

@joeyparrish can you review it? Thanks!

@theodab theodab changed the title fix(dash): dedup stream logic - 2 fix(dash): Account for bandwidth before filtering text stream Mar 22, 2022
@theodab theodab added component: captions/subtitles The issue involves captions or subtitles component: DASH The issue involves the MPEG DASH manifest format labels Mar 22, 2022
@theodab theodab merged commit 0b04aec into shaka-project:main Mar 22, 2022
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Merged
@king-prawns king-prawns deleted the fix-dedup-stream-2 branch March 22, 2022 20:07
joeyparrish pushed a commit that referenced this pull request Apr 21, 2022
@king-prawns @joeyparrish
fix(dash): Account for bandwidth before filtering text stream (#3765)
edd58fc 
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Apr 21, 2022
@king-prawns @joeyparrish
fix(dash): Account for bandwidth before filtering text stream (#3765)
c97438a 
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Merged
joeyparrish pushed a commit that referenced this pull request Apr 21, 2022
@king-prawns @joeyparrish
fix(dash): Account for bandwidth before filtering text stream (#3765)
612133e 
We filter out text streams that are duplicates, before persenting
them to the end user. A duplicate is detected by checking if
various values on the streams are the same.
However, we were not checking for bandwidth. This could lead to a
text stream being marked as a duplicate if it had the same language,
label, etc as another, even if they did not contain the same text.
This changes the utility to also check bandwidth.

Closes #3724
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Merged
@avelad avelad added this to the v4.0 milestone May 4, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles component: DASH The issue involves the MPEG DASH manifest format status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Some subtitles in the manifest are not shown in the player
3 participants
@king-prawns @avelad @theodab