-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Captions not working after a period transition on live DASH streams #3783
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
I'm going to submit a pull request to fix this. |
6 tasks
joeyparrish
pushed a commit
that referenced
this issue
Dec 13, 2021
… streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
…streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783 Change-Id: I0b99df9cf081a5ad340ac16344f5f0240633d683
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
…streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783 Change-Id: If34ff360dee76f03badef6a5b6c89751e1986285
joeyparrish
pushed a commit
that referenced
this issue
Jan 5, 2022
…streams (#3801) Embedded CEA-608 captions don't work on multi period live DASH DAI streams after new periods appear in the manifest because commas are appended the streams originalId string, which disrupts some stream matching code in text_engine.js The problem has been resolved by preventing makeTextStreamsForClosedCaptions() from altering the PeriodCombiner.textStreams_ array. Fixes #3783 Change-Id: I9abce3f34bf45d506325c13cb06c550d556c2d62
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Feb 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes i do not see a duplicate
What version of Shaka Player are you using?
3.1.2
Can you reproduce the issue with our latest release version?
I am certain the problem is present but I cannot reproduce because CEA 608 captions don't work at all because of this issue
#3782
Can you reproduce the issue with the latest code from
master
?No because CEA 608 captions are not working at all
Are you using the demo app or your own custom app?
Customer app
If custom app, can you reproduce the issue using our demo app?
No because CEA 608 captions are not working at all
What browser and OS are you using?
Chrome on Mac OS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
We will share stream information if necessary
What configuration are you using? What is the output of
player.getConfiguration()
?We will share the configuration information if necessary
What did you do?
Play a multi-period live stream with CEA 608 captions embedded and that text track selected.
What did you expect to happen?
We expect to see captions in all periods that contain captions data.
What actually happened?
Captions disappear when we transition to a new period.
Note that this problem does not occur with VOD streams
We have isolate the problem to this code in lib/text/text_engine.js storeAndAppendClosedCaptions()
At this point id is "CC1" and this.selectionCloseCaptionId_ is "CC1,,,," with the number of commas varying,
if we change this condition to this.selectedClosedCaptionId_.contains(id) captions work as expected.
The text was updated successfully, but these errors were encountered: