Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCD top bitrate (tb) is being reported incorrectly #3851

Closed
littlespex opened this issue Jan 12, 2022 · 0 comments · Fixed by #3852 or #4009
Closed

CMCD top bitrate (tb) is being reported incorrectly #3851

littlespex opened this issue Jan 12, 2022 · 0 comments · Fixed by #3852 or #4009
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@littlespex
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.3.0

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from master?
Yes

Are you using the demo app or your own custom app?
Both

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Safari, Chrome, Firefox, Edge

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

{
   cmcd: {
    enabled: true
  }
}

What did you do?

  1. Start playback of any stream
  2. View the network requests for any video or audio segments and inspect the CMCD query string

What did you expect to happen?

  • The tb (top bitrate) property should honor bitrate/size ABR constraints and only report the top playable bitrate.
  • The tb property should also only report the bandwidth for that segments type (audio, video, muxed).

What actually happened?

  • The tb property is the same for all requests, and it's locked to the bandwidth of the highest variant in the manifest.
  • The tb property is the same regardless of the segment type.
@littlespex littlespex added the type: bug Something isn't working correctly label Jan 12, 2022
@littlespex littlespex mentioned this issue Jan 12, 2022
11 tasks
@shaka-bot shaka-bot added this to the v3.3 milestone Jan 12, 2022
@joeyparrish joeyparrish added the priority: P1 Big impact or workaround impractical; resolve before feature release label Jan 12, 2022
joeyparrish pushed a commit that referenced this issue Jan 12, 2022
The tb (top bitrate) property should honor bitrate/size ABR constraints and only report the top playable bitrate.

The tb property should only report the bandwidth for that segments type (audio, video, muxed).

Fix incorrect top bitrate CMCD reporting by:

Honoring the player's current bitrate/size ABR constraints.
Only reporting the bandwidth for that segments type (audio, video, muxed).

Fixes #3851

Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish pushed a commit that referenced this issue Jan 28, 2022
The tb (top bitrate) property should honor bitrate/size ABR constraints and only report the top playable bitrate.

The tb property should only report the bandwidth for that segments type (audio, video, muxed).

Fix incorrect top bitrate CMCD reporting by:

Honoring the player's current bitrate/size ABR constraints.
Only reporting the bandwidth for that segments type (audio, video, muxed).

Fixes #3851

Co-authored-by: Dan Sparacio <[email protected]>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
@avelad avelad modified the milestones: v3.3, v4.0 May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
4 participants