Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing calc() from release CSS in v3.1.7, v3.2.5, and v3.3.3 #4155

Closed
joeyparrish opened this issue Apr 26, 2022 · 0 comments
Closed

Missing calc() from release CSS in v3.1.7, v3.2.5, and v3.3.3 #4155

joeyparrish opened this issue Apr 26, 2022 · 0 comments
Assignees
Labels
component: UI The issue involves the Shaka Player UI priority: P0 Broken for everyone; no workaround; urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
v3.3.3

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
No

Are you using the demo app or your own custom app?
N/A

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
N/A

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

N/A

What configuration are you using? What is the output of player.getConfiguration()?

N/A

What did you do?

Apparently, I made some mistakes when cherry-picking for our most recent round of releases. v3.1.7, v3.2.5, and v3.3.3 are all affected.

During a very messy upgrade-downgrade-upgrade process w/ less.js, calc() statements got incidentally removed, then added back. Commits that were cherry-picked to the release branches included the removal, but not the restoration. As a result, the CSS in those releases have several errors:

.shaka-skip-ad-container {
  right: (100 - @bottom-controls-width) / 2 * -1;
}
.shaka-play-button {
  padding: @play-button-size-percentage / 2;
}
.shaka-spinner {
  padding: @spinner-size-percentage / 2;
}
.range-container() {
  margin: (@thumb-size - @track-height)/2 6px;
}
.range-element() {
  top: (@track-height - @thumb-size) / 2;
}
.shaka-tooltips-on {
  & > [class*="shaka-tooltip"] {
    &:hover:after, &:focus-visible:after, &:active:after {
      line-height: @material-icons-width / 2;
      bottom: @material-icons-width + 5px;
      left: @material-icons-width / 2;
    }
  }
}

This was only caught because the final CSS from the v3.3.3 release was rejected by some internal tools when other Google projects tried to consume it. 😞

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P0 Broken for everyone; no workaround; urgent labels Apr 26, 2022
@joeyparrish joeyparrish self-assigned this Apr 26, 2022
joeyparrish added a commit to joeyparrish/shaka-player that referenced this issue Apr 26, 2022
@github-actions github-actions bot added this to the v3.3 milestone Apr 26, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jun 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: UI The issue involves the Shaka Player UI priority: P0 Broken for everyone; no workaround; urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

1 participant