Missing calc() from release CSS in v3.1.7, v3.2.5, and v3.3.3 #4155
Labels
component: UI
The issue involves the Shaka Player UI
priority: P0
Broken for everyone; no workaround; urgent
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
v3.3.3
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?No
Are you using the demo app or your own custom app?
N/A
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
N/A
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
N/A
What configuration are you using? What is the output of
player.getConfiguration()
?N/A
What did you do?
Apparently, I made some mistakes when cherry-picking for our most recent round of releases. v3.1.7, v3.2.5, and v3.3.3 are all affected.
During a very messy upgrade-downgrade-upgrade process w/ less.js, calc() statements got incidentally removed, then added back. Commits that were cherry-picked to the release branches included the removal, but not the restoration. As a result, the CSS in those releases have several errors:
This was only caught because the final CSS from the v3.3.3 release was rejected by some internal tools when other Google projects tried to consume it. 😞
The text was updated successfully, but these errors were encountered: