fix(hls): Fix X-PRELOAD-HINT failure with LL mode off #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When LL mode was off, the HLS parser would throw on X-PRELOAD-HINT segments. The logic for requiring EXTINF has been corrected so that this will not happen. Closes shaka-project#4185
joeyparrish
added
type: bug
littlespex
approved these changes
May 11, 2022
This was referenced May 11, 2022
joeyparrish
added a commit
that referenced
this pull request
May 17, 2022
When LL mode was off, the HLS parser would throw on X-PRELOAD-HINT segments. The logic for requiring EXTINF has been corrected so that this will not happen. Closes #4185
joeyparrish
added a commit
that referenced
this pull request
May 17, 2022
When LL mode was off, the HLS parser would throw on X-PRELOAD-HINT segments. The logic for requiring EXTINF has been corrected so that this will not happen. Closes #4185
joeyparrish
added a commit
that referenced
this pull request
May 17, 2022
When LL mode was off, the HLS parser would throw on X-PRELOAD-HINT segments. The logic for requiring EXTINF has been corrected so that this will not happen. Closes #4185
nyanmisaka
added a commit
to nyanmisaka/shaka-player
that referenced
this pull request
Oct 6, 2022
…project#4212)" This reverts commit ae84aac.
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LL mode was off, the HLS parser would throw on X-PRELOAD-HINT
segments. The logic for requiring EXTINF has been corrected so that
this will not happen.
Closes #4185