-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Populate track's spatialAudio property #4291
Merged
joeyparrish
merged 19 commits into
shaka-project:main
from
cbsinteractive:issue/4290-spatial-audio
Jun 13, 2022
Merged
fix: Populate track's spatialAudio property #4291
joeyparrish
merged 19 commits into
shaka-project:main
from
cbsinteractive:issue/4290-spatial-audio
Jun 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o stream's spatialAudio property
joeyparrish
approved these changes
Jun 13, 2022
joeyparrish
changed the title
fix: populate variant track's spatialAudio property based on the audio stream's spatialAudio property
fix: Populate variant track's spatialAudio property
Jun 13, 2022
joeyparrish
changed the title
fix: Populate variant track's spatialAudio property
fix: Populate track's spatialAudio property
Jun 13, 2022
Thanks! |
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks. Co-authored-by: Dan Sparacio <[email protected]>
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks. Co-authored-by: Dan Sparacio <[email protected]>
avelad
pushed a commit
that referenced
this pull request
Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks. Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish
pushed a commit
that referenced
this pull request
Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks. Co-authored-by: Dan Sparacio <[email protected]>
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Jul 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4290 where
spatialAudio
flag is not being set on variant tracks.