Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Populate track's spatialAudio property #4291

Merged

Conversation

littlespex
Copy link
Contributor

@littlespex littlespex commented Jun 13, 2022

Fixes issue #4290 where spatialAudio flag is not being set on variant tracks.

@joeyparrish joeyparrish changed the title fix: populate variant track's spatialAudio property based on the audio stream's spatialAudio property fix: Populate variant track's spatialAudio property Jun 13, 2022
@joeyparrish joeyparrish changed the title fix: Populate variant track's spatialAudio property fix: Populate track's spatialAudio property Jun 13, 2022
@joeyparrish
Copy link
Member

Thanks!

@joeyparrish joeyparrish merged commit 713f461 into shaka-project:main Jun 13, 2022
avelad pushed a commit that referenced this pull request Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
avelad pushed a commit that referenced this pull request Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
avelad pushed a commit that referenced this pull request Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
joeyparrish pushed a commit that referenced this pull request Jun 14, 2022
Fixes issue #4290 where `spatialAudio` flag is not being set on variant tracks.

Co-authored-by: Dan Sparacio <[email protected]>
@littlespex littlespex deleted the issue/4290-spatial-audio branch November 17, 2022 17:29
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants