Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill lib/polyfill/videoplaybackquality.js Not working on LG WebOS #4313

Closed
samueleastdev opened this issue Jun 23, 2022 · 2 comments · Fixed by #4316
Closed

Polyfill lib/polyfill/videoplaybackquality.js Not working on LG WebOS #4313

samueleastdev opened this issue Jun 23, 2022 · 2 comments · Fixed by #4316
Labels
platform: WebOS Issues affecting WebOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@samueleastdev
Copy link

samueleastdev commented Jun 23, 2022

Have you read the FAQ and checked for duplicate open issues?

Yes

What version of Shaka Player are you using?

Shaka: 4.1.1

Can you reproduce the issue with our latest release version?

Yes

Can you reproduce the issue with the latest code from main?

Yes

Are you using the demo app or your own custom app?

Basic custom setup

If custom app, can you reproduce the issue using our demo app?

Just testing with this: https://shaka-version-test-latest.s3.amazonaws.com/test2.html

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

LG WebOs 3.5 to 3.9 TVs

What did you do?

Run the url above on an LG TV WebOS and it will give this error.

Screen Shot 2022-06-22 at 5 54 56 PM

Seems the Polyfill for https://developer.mozilla.org/en-US/docs/Web/API/VideoPlaybackQuality doesnt seem to work for this device.

Shaka Polyfill: https://shaka-player-demo.appspot.com/docs/api/lib_polyfill_videoplaybackquality.js.html

Was just wondering if there is a workaround the TV navigator.userAgent says

Mozilla/5.0 (Web0S; Linux/SmartTV) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.122 Safari/537.36 WebAppManager 

Thanks

@samueleastdev samueleastdev added the type: bug Something isn't working correctly label Jun 23, 2022
@avelad avelad added the platform: WebOS Issues affecting WebOS label Jun 23, 2022
@github-actions github-actions bot added this to the v4.2 milestone Jun 23, 2022
@avelad
Copy link
Member

avelad commented Jun 24, 2022

I have been checking and it seems that in old versions of Chrome it is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.X.

@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jun 24, 2022
joeyparrish pushed a commit that referenced this issue Jun 26, 2022
It seems that webkitDroppedFrameCount is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.

Closes #4313
@samueleastdev
Copy link
Author

samueleastdev commented Jun 26, 2022

Thankyou 👍🏻

theodab pushed a commit to theodab/shaka-player that referenced this issue Jul 11, 2022
It seems that webkitDroppedFrameCount is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.

Closes shaka-project#4313
joeyparrish pushed a commit that referenced this issue Jul 14, 2022
It seems that webkitDroppedFrameCount is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.

Closes #4313
joeyparrish pushed a commit that referenced this issue Jul 14, 2022
It seems that webkitDroppedFrameCount is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.

Closes #4313
joeyparrish pushed a commit that referenced this issue Jul 14, 2022
It seems that webkitDroppedFrameCount is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.

Closes #4313
joeyparrish pushed a commit that referenced this issue Jul 14, 2022
It seems that webkitDroppedFrameCount is not included in the prototype but it is included in the video element itself, that's why it fails in WebOS 3.

Closes #4313
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: WebOS Issues affecting WebOS priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants