Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEA608 captions show (Braille pattern blank) instead of whitespace #6328

Closed
dhmmNagra opened this issue Mar 6, 2024 · 1 comment · Fixed by #6329 or #5987
Closed

CEA608 captions show (Braille pattern blank) instead of whitespace #6328

dhmmNagra opened this issue Mar 6, 2024 · 1 comment · Fixed by #6329 or #5987
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@dhmmNagra
Copy link

Have you read the FAQ and checked for duplicate open issues?
YES

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?
v4.7.11-uncompiled

Can you reproduce the issue with our latest release version?
YES

Can you reproduce the issue with the latest code from main?
YES

Are you using the demo app or your own custom app?
The demo

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/121.0.0.0 Safari/537.36

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
uri= https://livesim2.dashif.org/livesim2/testpic_2s/cea608.mpd

What configuration are you using? What is the output of player.getConfiguration()?

Standard config from the demo

What did you do?

  1. Play the stream
  2. Enable captions by selecting eng from the menu
  3. Observe the text/captions displayed on the screen

What did you expect to happen?
eng: 00:34:21:00 i.e. whitespace between the : and the timestamp.

What actually happened?

Shaka screenshot with wrong character

A (Braille pattern blank) is observed instead of whitespace.

FYI DASH.js renders whitespace
DASH.js comparison

@dhmmNagra
Copy link
Author

This traces to

[0x36, '£'], [0x37, '♪'], [0x38, 'à'], [0x39, '⠀'], [0x3a, 'è'], [0x3b, 'â'],

shaka.cea.Cea608Memory.CharSet.SpecialNorthAmericanChars = new Map([
  [0x30, '®'], [0x31, '°'], [0x32, '½'], [0x33, '¿'], [0x34, '™'], [0x35, '¢'],
  [0x36, '£'], [0x37, '♪'], [0x38, 'à'], [0x39, '⠀'], [0x3a, 'è'], [0x3b, 'â'],
  [0x3c, 'ê'], [0x3d, 'î'], [0x3e, 'ô'], [0x3f, 'û'],
]);

Currently working on a fix for it.

@avelad avelad added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release labels Mar 6, 2024
@avelad avelad added this to the v5.0 milestone Mar 6, 2024
joeyparrish pushed a commit that referenced this issue Mar 6, 2024
Ensure whitespace rendered in CEA-608 test streams instead of `⠀` (braille pattern blank).
Updated UT too, but avoiding this char at ends of the string hence vulnerable to trim() 🤦 

Fixes #6328
avelad pushed a commit that referenced this issue Apr 8, 2024
Ensure whitespace rendered in CEA-608 test streams instead of `⠀` (braille pattern blank).
Updated UT too, but avoiding this char at ends of the string hence vulnerable to trim() 🤦 

Fixes #6328
avelad pushed a commit that referenced this issue Apr 8, 2024
Ensure whitespace rendered in CEA-608 test streams instead of `⠀` (braille pattern blank).
Updated UT too, but avoiding this char at ends of the string hence vulnerable to trim() 🤦 

Fixes #6328
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 5, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators May 5, 2024
joeyparrish pushed a commit that referenced this issue May 7, 2024
Ensure whitespace rendered in CEA-608 test streams instead of `⠀` (braille pattern blank).
Updated UT too, but avoiding this char at ends of the string hence vulnerable to trim() 🤦 

Fixes #6328
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
3 participants