Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InbandEventStream at Representation level being ignored #686

Closed
sanbornhilland opened this issue Feb 7, 2017 · 0 comments
Closed

InbandEventStream at Representation level being ignored #686

sanbornhilland opened this issue Feb 7, 2017 · 0 comments
Labels
status: archived Archived and locked; will not be updated

Comments

@sanbornhilland
Copy link
Contributor

Reproducible on master

It appears that <InbandEventStream> elements are being ignored if they are present at the Representation level.

For example these are being ignored (http://demo.yospace.com/quickplay/dash/vod.mpd):

<AdaptationSet contentType="video" par="640:360" minWidth="640" maxWidth="640" minHeight="360" maxHeight="360" mimeType="video/mp4" codecs="avc1.4d401f">
  <Representation id="0" bandwidth="300000" width="640" height="360" sar="1:1" frameRate="30">
    <InbandEventStream schemeIdUri="urn:yospace:a:id3:2016" value="0"/>
    <SegmentTemplate media="ad1/u-6600-b-640x360-300-1-$Number$.mp4" initialization="ad1/u-6600-b-640x360-300-1-i.mp4" startNumber="0" timescale="15360">
      <SegmentTimeline>
        <S d="122880"/>
        <S d="108032"/>
      </SegmentTimeline>
    </SegmentTemplate>
  </Representation>
</AdaptationSet>

The dash_parser only searches the immediate children of the <AdaptationSet>:

var eventStream = XmlUtils.findChild(elem, 'InbandEventStream');
var containsInband = eventStream != null;

In the version of the DASH spec that I have(Second edition 2014-05-15) it says in 5.10.3.2 that:

An inband event stream that is present in a Representation shall be indicated by an InbandEventStream element on Adaptation Set or Representation level.

So I believe the test asset above is correct and Shaka should not be ignoring these.

sanbornhilland added a commit to sanbornhilland/shaka-player that referenced this issue Feb 7, 2017
sanbornhilland added a commit to sanbornhilland/shaka-player that referenced this issue Feb 8, 2017
sanbornhilland added a commit to sanbornhilland/shaka-player that referenced this issue Feb 9, 2017
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

No branches or pull requests

2 participants