Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MSS): Fix timeline repetitions #7484

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 24, 2024

Fixes #7483

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release component: MSS The issue involves Microsoft Smooth Streaming manifest format labels Oct 24, 2024
@avelad avelad added this to the v4.12 milestone Oct 24, 2024
Copy link
Member

@tykus160 tykus160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add unit tests for repeat?

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad
Copy link
Member Author

avelad commented Oct 24, 2024

Can you add unit tests for repeat?

Done!

@avelad avelad requested a review from tykus160 October 24, 2024 07:30
@avelad avelad merged commit b1d3a3a into shaka-project:main Oct 24, 2024
16 of 18 checks passed
@avelad avelad deleted the mss-repeat branch October 24, 2024 08:00
avelad added a commit that referenced this pull request Oct 24, 2024
avelad added a commit that referenced this pull request Oct 24, 2024
avelad added a commit that referenced this pull request Oct 24, 2024
joeyparrish pushed a commit that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: MSS The issue involves Microsoft Smooth Streaming manifest format priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shaka doesn't work with Azure Media Services Smooth Streaming Manifests
3 participants