Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: fullscreen button disappears #787

Closed
joeyparrish opened this issue May 5, 2017 · 2 comments
Closed

IE11: fullscreen button disappears #787

joeyparrish opened this issue May 5, 2017 · 2 comments
Assignees
@michellezhuogg
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

  • What version of Shaka Player are you using? v2.1.0 and nightly
  • Are you using the demo app or your own custom app? demo app
  • What browser and OS are you using? IE11 on Windows 10
  • What did you do?
  1. Click "load"
  2. Try to go fullscreen
  • What actually happened?

The fullscreen button is missing from the controls UI.

Manual inspection of the DOM reveals <div id="controls" class="casting">. After clicking "load", the player starts thinking we are in casting mode, and CSS hides the fullscreen button. It is still present before "load".
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label May 5, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone May 5, 2017
@joeyparrish joeyparrish mentioned this issue May 5, 2017
Merged
@michellezhuogg
Copy link
Contributor

The root cause:
IE11 doesn't support the second parameter of toggle() method.
https://github.com/google/shaka-player/blob/master/demo/controls.js#L553
http://caniuse.com/#search=classList

joeyparrish pushed a commit that referenced this issue Jul 17, 2017
@michellezhuogg @joeyparrish
Fix IE11 Fullscreen button disappearance
4903467 
In IE11, the fullscreen button in the controls UI disappears after
clicking 'Load'. This is because the classList toggle method is not
fully supported for IE11, so the 'casting' class is added to the
controls div every time. Fixing by using add and remove instead of
toggle.

Closes #787.

Change-Id: I9c4f2cfdc32d1ed11e3a4b5b86e885bd8c10db3d
@joeyparrish
Copy link
Member Author

The fix for this has been cherry-picked and will be released in v2.1.5.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellezhuogg michellezhuogg

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @michellezhuogg