Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to audio-only variant fails #824

Closed
joeyparrish opened this issue May 19, 2017 · 1 comment
Closed

Switching to audio-only variant fails #824

joeyparrish opened this issue May 19, 2017 · 1 comment
Assignees
@theodab
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

It is common for HLS manifests to have an audio-only variant. This doesn't work today, largely because of MediaSource. We can't easily reconfigure MediaSource to drop the video SourceBuffer if we switch to the audio-only variant. What happens today is that StreamingEngine continues to stream the video from the previous variant.

We may not be able to support this kind of switching on top of MediaSource, in which case we should ignore audio-only variants when there are any variants with video. More research is needed.
@joeyparrish joeyparrish added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format labels May 19, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone May 19, 2017
@joeyparrish joeyparrish modified the milestones: v2.2.0, v2.3.0 Jun 6, 2017
@joeyparrish joeyparrish mentioned this issue Jun 8, 2017
Closed
@joeyparrish joeyparrish modified the milestones: v2.2.0, v2.3.0 Jun 8, 2017
@theodab theodab added type: bug Something isn't working correctly and removed type: enhancement New feature or request labels Jun 21, 2017
joeyparrish pushed a commit that referenced this issue Jul 17, 2017
@theodab @joeyparrish
Filters out single-stream variants.
e256dc3 
In situations where there are variants with video and audio, and variants
with only one of the two, this filters out the less-complete variants.
This removes the possibility of the player switching to an audio-only
variant and breaking MediaSource. It also solves the regression where
audio-only variants have the lowest bandwidth and thus are chosen
preferentially on weak connections.

Closes #824
Closes #861

Change-Id: Ic37543d98962ddd83a85224e26e5225d142b844e
@joeyparrish
Copy link
Member Author

The fix for this has been cherry-picked and will be released in v2.1.5.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @theodab