Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception in v2.1.5 demo app in compiled mode #929

Closed
joeyparrish opened this issue Jul 17, 2017 · 1 comment
Closed

Exception in v2.1.5 demo app in compiled mode #929

joeyparrish opened this issue Jul 17, 2017 · 1 comment
Assignees
@theodab
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

shakaDemo.player_.defaultConfig_ is not accessible in compiled mode and causes an exception in the demo app. I didn't catch it before I tagged v2.1.5.

This only affects the demo and no other applications. The bug is in the demo itself. This should be fixed before v2.2.0 and cherry-picked to v2.1.6.
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Jul 17, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Jul 17, 2017
joeyparrish pushed a commit that referenced this issue Jul 19, 2017
@theodab @joeyparrish
Removed defaultConfig_ reference in demo.
bf61d89 
defaultConfig_ is not accessible in compiled mode, and thus the code
using it caused an error.
This simply sets the smallGapLimit placeholder to 0.5, instead of
looking it up from defaultConfig_.

Closes #929

Change-Id: I2e81669858bff2e555e638e282c0643f5ea70ac0
@joeyparrish
Copy link
Member Author

The fix has been cherry-picked for v2.1.6.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @theodab