Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly disabling ABR when selecting tracks #962

Closed
bhh1988 opened this issue Aug 10, 2017 · 2 comments
Closed

Explicitly disabling ABR when selecting tracks #962

bhh1988 opened this issue Aug 10, 2017 · 2 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Milestone

Comments

@bhh1988
Copy link
Contributor

bhh1988 commented Aug 10, 2017

Looking at the docs here: https://github.com/google/shaka-player/blob/master/docs/tutorials/upgrade-v2-0.md

The example shows calling player.configure() AFTER selectVariantTrack(), to disable ABR. That doesn't seem to work well in practice. It seems better to call player.configure() to disable ABR BEFORE calling selectVariantTrack(). I think either the docs should change to reflect that, or the code should change to reflect the docs - my guess is that the problem is that inside of player.js's applyConfig_() method chooseStreamsAndSwitch_() is called before actually disabling ABR. It seems that most any call to player.configure() will potentially undo a previous selectVariantTrack() call.

I was testing this on HEAD of master about one week ago.

@joeyparrish joeyparrish added the type: docs Improvements or fixes to documentation label Aug 10, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone Aug 10, 2017
@joeyparrish joeyparrish self-assigned this Aug 10, 2017
@joeyparrish
Copy link
Member

You are correct. We disable ABR first in the demo app, so the docs are at fault.

joeyparrish added a commit that referenced this issue Aug 10, 2017
ABR should be disabled before selecting a new track.  The demo app
does it right, but the upgrade docs had it in the wrong order.

Closes #962

Backported to v2.1.x

Change-Id: I57020098f24401c7d56acfe050cf2363cd22621f
@joeyparrish
Copy link
Member

The fix has been cherry-picked for v2.1.7.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Projects
None yet
Development

No branches or pull requests

3 participants