Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo: auto-select offline copy of asset after storing #996

Closed
beaufortfrancois opened this issue Aug 28, 2017 · 4 comments
Closed

Demo: auto-select offline copy of asset after storing #996

beaufortfrancois opened this issue Aug 28, 2017 · 4 comments
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@beaufortfrancois
Copy link
Contributor

beaufortfrancois commented Aug 28, 2017

navigator.userAgent
"Mozilla/5.0 (Linux; Android 8.0.0; Pixel Build/OPR6.170623.012) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3194.0 Mobile Safari/537.36"

Steps to reproduce:

  1. Go to https://nightly-dot-shaka-player-demo.appspot.com/demo/#asset=//storage.googleapis.com/shaka-demo-assets/angel-one-widevine/dash.mpd;lang=en-US
  2. Click "Load" button
  3. Expand "Offline section" and click "Store" button
  4. Wait for asset to be fully downloaded.
  5. Select another asset and click "Load" button
  6. Turn ON airplane mode (meaning no internet connection)
  7. Select back "Angel One (multicodec, multilingual, Widevine)" asset\
  8. Click "Load" button

Expected result:
Video plays.

What happens instead:
I get the error below:

Shaka Error DRM.LICENSE_REQUEST_FAILED (shaka.util.Error {
  "severity": 2,
  "category": 1,
  "code": 1002,
  "data": [
    "http://widevine-proxy.appspot.com/proxy"
  ],
  "handled": false,
  "message": "Shaka Error NETWORK.HTTP_ERROR (http://widevine-proxy.appspot.com/proxy)",
  "stack": "Error: Shaka Error NETWORK.HTTP_ERROR (http://widevine-proxy.appspot.com/proxy)\n    at new shaka.util.Error (http://localhost:4000/lib/util/error.js:66:13)\n    at XMLHttpRequest.xhr.onerror (http://localhost:4000/lib/net/http_plugin.js:91:14)"
})
@beaufortfrancois
Copy link
Contributor Author

And I've just realized an "Offline asset" has been added to the dropdown list...
I believe this makes my issue WAI.

@beaufortfrancois
Copy link
Contributor Author

I'm closing this issue and updating the existing PR: #995

@joeyparrish
Copy link
Member

I'm glad you figured it out, but it should be more obvious. For example, we could automatically select the offline copy in the list after storing it. I'm going to reopen this and schedule it for v2.3, but a demo app usability improvement like this could also be cherry-picked to v2.2.x releases.

@joeyparrish joeyparrish reopened this Aug 29, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Aug 29, 2017
@joeyparrish joeyparrish added flag: good first issue This might be a relatively easy issue; good for new contributors type: enhancement New feature or request labels Aug 29, 2017
@joeyparrish joeyparrish changed the title Demo: LICENSE_REQUEST_FAILED error shows up when asset is already stored Demo: auto-select offline copy of asset after storing Aug 29, 2017
@joeyparrish
Copy link
Member

The fix has been cherry-picked to v2.2.x and will be released in v2.2.2.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants