Publish an event from DrmEngine if the CDM accepts the license. #1049
Conversation
| @@ -46,6 +46,8 @@ describe('DrmEngine', function() { | |||
| var onKeyStatusSpy; | |||
| /** @type {!jasmine.Spy} */ | |||
| var onExpirationSpy; | |||
| /** @type {!jasmine.Spy} */ | |||
| var onEventSpy; | |||
There was a problem hiding this comment.
I created this spy but don't actually use it for anything. Suggestions?
There was a problem hiding this comment.
I'm not sure we need a separate integration test for this, but you could always expect that onEvent was called at the appropriate time in the "basic flow" test below.
Note that DRM integration tests are only run if you use ./build/test.py --drm.
There was a problem hiding this comment.
I've left this as is. The new behaviour is already covered by a unit test, and I noticed that onExpirationSpy is similarly unused in drm_engine_integration. I'll leave it to you guys to decide whether you need these spies.
| .then(function(response) { | ||
| if (this.destroyed_) return Promise.reject(); | ||
|
|
||
| // Request succeeded, now pass the response to the CDM. | ||
| return session.update(response.data).then(function() { | ||
| var event = new shaka.util.FakeEvent('drmsessionupdate'); |
There was a problem hiding this comment.
Please document this event type in lib/player.js. You'll see several examples toward the top of the file.
| @@ -46,6 +46,8 @@ describe('DrmEngine', function() { | |||
| var onKeyStatusSpy; | |||
| /** @type {!jasmine.Spy} */ | |||
| var onExpirationSpy; | |||
| /** @type {!jasmine.Spy} */ | |||
| var onEventSpy; | |||
There was a problem hiding this comment.
I'm not sure we need a separate integration test for this, but you could always expect that onEvent was called at the appropriate time in the "basic flow" test below.
Note that DRM integration tests are only run if you use ./build/test.py --drm.
|
No, I don't think I need to add new integration tests. |
|
All tests passed! |
|
Thanks, Chris! |
|
Cherry-picked to v2.2.3. |
github-actions
bot
added
the
status: archived
Resolves #1035