Render bold/italics/underline on SimpleTextDisplayer #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muhammadharis
commented
Aug 11, 2020
| [shakaCue]); | ||
| }); | ||
|
|
||
| it('adds linebreaks when a linebreak cue is seen', () => { |
There was a problem hiding this comment.
Although it doesn't directly relate to the goal of this pull, I thought I might as well add a unit test for this as well.
joeyparrish
requested changes
Aug 11, 2020
lib/text/simple_text_displayer.js
Outdated
| @@ -82,8 +82,25 @@ shaka.text.SimpleTextDisplayer = class { | |||
| // Flatten nested cue payloads recursively. If a cue has nested cues, | |||
| // their contents should be combined and replace the payload of the parent. | |||
| const flattenPayload = (cue) => { | |||
| // TODO: If we want to support bold, italic, underline here, we would | |||
| // insert markup into the payload. | |||
| // Handle styles (currently underlines/italics). TODO support for color. | |||
There was a problem hiding this comment.
Could you add support for bold? Something like cue.fontWeight >= shaka.text.Cue.fontWeight.BOLD?
| [shakaCue]); | ||
| }); | ||
|
|
||
| it('adds linebreaks when a linebreak cue is seen', () => { |
small comment fix
muhammadharis
force-pushed
the
simpletextdisplayer-styling
branch
from
2b01c09
to
7e72472
Compare
muhammadharis
changed the title
|
All tests passed! |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also pertains to #2648.