Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playready multikey restrictions #3052

Closed

Conversation

sarge
Copy link

@sarge sarge commented Dec 17, 2020

Please note this is not a PR for merging - this is only to help recreate an issue I have seen.

Here is a rough cut of the changes I have made.

I successfully get to a set of variants with a mix of allowedByKeySystem:true and allowedByKeySystem:false.

I can see a variant selected that is allowedByKeySystem:true.

I can see buffers are full. Seeking keeps the buffers loading.

What would trigger the actual playback?

btw - I haven't started to think about the offline considerations.

@google-cla
Copy link

google-cla bot commented Dec 17, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sarge
Copy link
Author

sarge commented Dec 18, 2020

@googlebot I signed it!

this.allSessionsLoaded_.reject(err);
playerInterface.onError(err);
};

this.licenseRequestCount_ = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than hard-code the retries. Can you try to make it customizable in format of default argument in a method.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenluck2001 this PR is just to help recreate a issue I have seen when rejecting license requests. This code is not for merging.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenluck2001 Thank you for your review!
@sarge It may not be the best way to use Pull Requests as code snippets. Please submit an issue if you still have a question so that we can keep track.
We'll close this pull request since it's not for merging. Thank you for understanding!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michellezhuogg I appreciate you looking at this. I submitted an issue #3051 and created this to reduce the friction in reproducing the issue. Open to suggestions on how to progress this.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants