Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI change: remove icon outline #3231

Closed
wants to merge 2 commits into from
Closed

UI change: remove icon outline #3231

wants to merge 2 commits into from

Conversation

dhruvil-shah
Copy link

Made some minor changes in UI:
1)As Outline of icons were a quite bit confusing for user when clicking it get's selected which might get user feel that he/she is selecting various options at the time of video streaming. So removed it.
2)Solved Overflow issue.
Also want to know if instead of giving play button explicitly we can make video streamed on image click is a good approach or not?

image

image

@michellezhuogg
Copy link
Contributor

  1. Would you like to take one step at a time and submit the outline fix first?
  2. There's an ongoing discussion about the overflow menu in PR 3220.
  3. Let's keep the play button as it is now.

Thank you!

@michellezhuogg michellezhuogg changed the title UI change UI change: remove icon outline Mar 15, 2021
@theodab
Copy link
Contributor

theodab commented Mar 16, 2021

The focus outline on icons is required for accessibility reasons. Without it, if you navigate through the webpage solely via keyboard (e.g. using the tab key), it will be difficult to tell what you currently are focusing on.
Focus outlines are considered a level AA (medium-importance) accessibility feature by the WCAG. You could argue that the tooltip counts as an "author-supplied, highly visible focus indicator" (see technique G195), but I'm not convinced myself.

@michellezhuogg
Copy link
Contributor

michellezhuogg commented Mar 16, 2021

Oh how can I forgot that. Thank you for your input @theodab !
There's actually no update required on our side. @dhruvil-shah would you be ok to close the PR if you don't have anything to update?

@dhruvil-shah
Copy link
Author

Oh how can I forgot that. Thank you for your input @theodab !
There's actually no update required on our side. @dhruvil-shah would you be ok to close the PR if you don't have anything to update?

Yes sir, No problem

@dhruvil-shah dhruvil-shah deleted the UI-change branch March 17, 2021 14:13
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants